Modify

Opened 3 years ago

Closed 3 years ago

Last modified 5 weeks ago

#13138 closed enhancement (fixed)

Warn about water=* without natural=water

Reported by: mdk Owned by: team
Priority: normal Milestone: 16.07
Component: Core validator Version: latest
Keywords: template_report Cc:

Description

What steps will reproduce the problem?

  1. Draw a closed way with water=pond
  2. Validate

What is the expected result?

Validator warning about water=pond without required natural=water.

What happens instead?

No warnings or infos from validator.

Please provide any additional information below. Attach a screenshot if possible.

I currently mapping in an area where I found closed ways with only one tag: water=pond.

According to the wiki, any water=* tag requires natural=water. So we could also offer a fix for adding the missing tag.
https://wiki.openstreetmap.org/wiki/Key:water also shows that natural=water & water=pond is equal to landuse=pond.
But https://wiki.openstreetmap.org/wiki/Tag:landuse%3Dpond says that landuse=pond is deprecated and should be replaced by natura=water & water=pond. Also in this case I would expect a validator warning about deprecated tag value and a fix to replace. But actual the validator only creates an info about an unknown value pond for the key water.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-07-11 23:04:49 +0200 (Mon, 11 Jul 2016)
Build-Date:2016-07-12 01:31:48
Revision:10526
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10526 en) Linux Ubuntu 15.10
Memory Usage: 352 MB / 876 MB (171 MB allocated, but free)
Java version: 1.8.0_91-8u91-b14-0ubuntu4~15.10.1-b14, Oracle Corporation, OpenJDK Server VM
VM arguments: [-Djosm.restart=true, -Djosm.home=<josm.pref>, -Djava.net.useSystemProxies=true]
Dataset consistency test: No problems found

Plugins:
- ColumbusCSV (32359)
- FastDraw (32639)
- HouseNumberTaggingTool (32584)
- Mapillary (32639)
- OpeningHoursEditor (32583)
- RoadSigns (32584)
- apache-commons (32584)
- apache-http (32584)
- buildings_tools (32639)
- contourmerge (1014)
- imagery-xml-bounds (32489)
- imagery_offset_db (32528)
- pbf (32584)
- poly (32584)
- public_transport (32639)
- reltoolbox (32639)
- reverter (32584)
- terracer (32426)
- turnlanes (32584)
- turnrestrictions (32629)
- utilsplugin2 (32584)

Tagging presets:
- https://josm.openstreetmap.de/josmfile?page=Presets/LaneAttributes&preset&zip=1
- https://josm.openstreetmap.de/josmfile?page=Presets/OneClick&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Maxspeed&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Traffic_signs&zip=1

Last errors/warnings:
- W: Unable to delete file <josm.pref>/cache/tiles/TMS.data
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_BLOCK.key
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_BLOCK.data
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_INDEX.key
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_INDEX.data
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_INDEX_v2.key
- W: Unable to delete file <josm.pref>/cache/tiles/TMS_INDEX_v2.data
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog$ApplyAction@1602287
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.conflict.tags.CombinePrimitiveResolverDialog$CancelAction@17ad6a9
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.help.ContextSensitiveHelpAction@119af3

Attachments (0)

Change History (4)

comment:1 Changed 3 years ago by Klumbumbus

Milestone: 16.07
Type: defectenhancement

comment:2 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 10538/josm:

fix #13138 - add warnings for water without natural=water and landuse=pond

comment:3 Changed 5 weeks ago by Klumbumbus

false positive for amenity=lavoir, see https://github.com/osm-fr/osmose-backend/issues/475

comment:4 Changed 5 weeks ago by Klumbumbus

In 14883/josm:

see #13138 - don't warn about water=* on amenity=lavoir (see https://github.com/osm-fr/osmose-backend/issues/475)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.