Modify

Opened 5 years ago

Closed 5 years ago

Last modified 4 years ago

#13114 closed defect (fixed)

External Advertising Preset

Reported by: Klumbumbus Owned by: Barnes38
Priority: normal Milestone:
Component: External preset Version:
Keywords: Cc:

Description

Hi Barnes,
please have a look at the history of the Advertising preet: https://josm.openstreetmap.de/wiki/Presets/AdvertisingPreset?action=history

There were several fixes and improvements made in versions 11-16.
It seems you did't notice and updated the preset in version 17 based on the old version 10.

I suggest that you revert the last two versions 18 and 17 and do your changes again based on version 16.

Attachments (0)

Change History (8)

comment:1 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

Thanks for fast fix. Please note that there are already some further adjustments again. When you edit the preset always copy the current version from the source code text box after clicking on edit and not from the rendered page.

To use icons, which are not included by default in JOSM (e.g. Panneau.svg) simply attach them to the preset page. More info about icons see Styles. (Also make sure that the license of the image is compatible, e.g. PD or CC0)

comment:2 Changed 5 years ago by Klumbumbus

comment:3 Changed 5 years ago by Klumbumbus

Please have a look at the icon names. Some are broken again.

W: 7. Colonne (de type 'Morris'): Could not get presets icon images/column.png, W: 7. Column: Could not get presets icon images/column.png, W: 8. Panneau publicitaire mural: Could not get presets icon images/billboard43_wall.png, W: 8. Wall advertising billboard: Could not get presets icon images/billboard43_wall.png, W: 11. Dispositif publicitaire non prédéfini: Could not get presets icon images/billboard43_trunk.png, W: 9. Grounded billboard: Could not get presets icon images/billboard43_trunk.png, W: 9. Panneau publicitaire scellé au sol: Could not get presets icon images/billboard43_trunk.png, W: 6. Totem: Could not get presets icon images/totem.png, W: 11. Undefined advertising device: Could not get presets icon images/billboard43_trunk.png

Also note that you don't need to test changes to presets directly on the wiki page. You can make changes on a local file, add it to JOSM and test it there. Once you are done with all your tests you can transfer your changes to the wiki page.

comment:4 Changed 5 years ago by Klumbumbus

Please before editing a wiki preset always have a look at the history of the wiki page if someone else made changes, so you don't accidently revert them. (Or use the preview function of the wiki to check for unwanted changes before submitting your changes.)

comment:5 Changed 5 years ago by Barnes38

OK, sorry, I didn't know other people were modifying this file !
I ll take care of that from now
Thanks for your patience!

comment:6 Changed 4 years ago by Klumbumbus

Please make sure to not adjust the line version="0.[[revision]]_[[date]]" when you edit your preset.

comment:7 Changed 4 years ago by anonymous

Oh! What should be done then, leave it blank ?

comment:8 in reply to:  7 Changed 4 years ago by stoecker

Replying to anonym:

Oh! What should be done then, leave it blank ?

Leave it to version="0.[[revision]]_[[date]]" not replacing the [[revision]] and [[date]] with any value. These markers will automatically replaced when file is delivered.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Barnes38.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.