Modify ↓

Opened 7 years ago

Closed 7 years ago

#13071 closed enhancement (fixed)

[Patch] Make DateUtilsTest.testTsFromString and ExifReaderTest.test* pass

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 16.06
Component: Unit tests Version:
Keywords: gsoc-core Cc: Don-vip, bastiK, stoecker

Description

Set the time zone explicitly to make that test pass again.

Attachments (2)

patch-test-DateUtilsTest-testTsFromString.patch​ (1.2 KB) - added by michael2402 7 years ago.
patch-fix-13071-2.patch​ (9.3 KB) - added by michael2402 7 years ago.

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by michael2402

Attachment: patch-test-DateUtilsTest-testTsFromString.patch​ added

comment:1 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: new → closed

In 10495/josm:

fix #13071 - Make DateUtilsTest.testTsFromString pass (patch by michael2402) - gsoc-core

comment:2 Changed 7 years ago by Don-vip

Resolution: fixed
Status: closed → reopened

it doesn't seem to work

comment:3 Changed 7 years ago by michael2402

Hmm, it did work locally. There is still something wrong with the global sate in the time tests since there are more tests failing now. I'll have a look at it...

While I'm at it: Is there any requirement for storing the time zone twice (once in DateUtils in the Calendar object and once in jara TimeZone class)? If not, i would remove that capability from DateUtils and simply use TimeZone.getDefault() every time.

comment:4 Changed 7 years ago by bastiK

Summary: [Patch] Make DateUtilsTest.testTsFromString pass → Make DateUtilsTest.testTsFromString pass

comment:5 in reply to:  3 Changed 7 years ago by Don-vip

Replying to michael2402:

While I'm at it: Is there any requirement for storing the time zone twice

Probably two developers made the same thing differently :) go ahead if setting it once is enough

comment:6 Changed 7 years ago by Don-vip

Component: Core → Unit tests
Milestone: → 16.06

comment:7 Changed 7 years ago by Don-vip

Summary: Make DateUtilsTest.testTsFromString pass → Make DateUtilsTest.testTsFromString and ExifReaderTest.test* pass

ExifReaderTest.test* are failing too.

Changed 7 years ago by michael2402

Attachment: patch-fix-13071-2.patch​ added

comment:8 Changed 7 years ago by michael2402

Summary: Make DateUtilsTest.testTsFromString and ExifReaderTest.test* pass → [Patch] Make DateUtilsTest.testTsFromString and ExifReaderTest.test* pass

I changed the time setting to only use one global time zone.

The exif reader test does not expect Europe/Berlin any more.

comment:9 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: reopened → closed

In 10513/josm:

fix #13071 - Make DateUtilsTest.testTsFromString and ExifReaderTest.test* pass (patch by michael2402) - gsoc-core

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.