download object leads to objects downloaded to nirvana

[dieterdreist]

What steps will reproduce the problem?

1. download object (and referers) from the file menu with no data layer available and "download to new layer" not checked

What is the expected result?

a new layer gets created (as there was none) and the objects end up there

What happens instead?

no layer is created and I don't know where the objects are, but if I select all I see many of them in the windows on the right (see screenshot, note that there is no data layer). When I select view-> zoom to data, nothing is happening

Please provide any additional information below. Attach a screenshot if possible.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-06-17 02:58:36 +0200 (Fri, 17 Jun 2016)
Build-Date:2016-06-17 01:34:23
Revision:10409
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10409 en) Mac OS X 10.11.5
Memory Usage: 729 MB / 1820 MB (231 MB allocated, but free)
Java version: 1.8.0_66-b17, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Dsun.java2d.opengl=true]
Dataset consistency test: No problems found

Plugins:
- TombPlugin (46)
- alignways (32161)
- apache-commons (32158)
- apache-http (32158)
- buildings_tools (32158)
- ejml (32158)
- geochat (32158)
- geotools (31895)
- imagery_offset_db (32158)
- jts (31906)
- opendata (32289)
- print (32191)
- proj4j (32158)
- reltoolbox (32158)
- reverter (32158)
- undelete (32158)
- utilsplugin2 (32158)

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/Lane_and_Road_Attributes&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/MaxspeedIcons&zip=1

Last errors/warnings:
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.SetRoleAction@66ed4ee9
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.ReferringRelationsBrowser$ReloadAction@6c3ff79b
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.ReferringRelationsBrowser$EditAction@4cfe6a52
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.OKAction@6cafaab6
- W: Old style SideButton usage for action org.openstreetmap.josm.gui.dialogs.relation.actions.CancelAction@630b5ced

[michael2402]

I just tested this and cannot reproduce it using revision [10411], the plugins you have and the relations 4525457,2014364.

Does this happen with all id lists for you?

[dieterdreist]

yes, I must admit I can't reproduce either with the current version. Don't know how this happened, now it all works fine and a new data layer gets created even if the object doesn't exist (404) (this might be questionable as well, but is out of scope for this ticket).

[dieterdreist]

Sorry, but it happened again, I'm reopening this. Actually, what I am doing and have been doing also the other time:
download an object, do some modifications, upload, remove the data layer.
After having done this several times, all of a sudden it doesn't show a data layer, but the data is there somehow. Interestingly, I was even able to add a tag and upload (because the object in question was already selected, 1st screenshot after "download object"), but when I select all, I don't see any data, but a lot of stuff is selected (although I only downloaded 1 node plus referrers, see 2nd screenshot

[dieterdreist]

after download object (1 node downloaded)

[dieterdreist]

after select all

[dieterdreist]

this is the changeset I created "blindly": ​https://www.openstreetmap.org/changeset/40201308

[Don-vip]

this looks like a major regression we should not release until this is understood/fixed.

[michael2402]

This seems to be a problem in the layer list. There might be two things causing this:

• LayerListDialog table does not realize it needs to update - It should have been registered as action listener all the time since there were always layers present. So it should receive the layer added event and do a fireTableDataChanged
• LayerListDialog forgetting the layer - But it queries the layer list directly from the layer manager
• Layer not included in the layer list - But the active layer is set after adding it to the layer list.
• ??? Some complex correlation of those three or some race condition...

Has anyone been able to reproduce this?

@dieterdreist if it ever happens again: Can you try hiding and then reopening the side layer dialog? Can you try adding an other new layer?

[dieterdreist]

ok, I'll try these next time it happens.

[Don-vip]

not reproduced since?

[Don-vip]

@Stereo: did you experience this as well with JOSM latest on MacOS?

[Don-vip]

No news, let's fix it in next release. As almost all MacOS users are using Java 8 it's OK.