Modify

Opened 3 years ago

Closed 3 years ago

#12864 closed defect (fixed)

misleading warning for some routes without network

Reported by: Hufkratzer Owned by: Klumbumbus
Priority: normal Milestone: 16.06
Component: Core validator Version: tested
Keywords: route network validator Cc: Hufkratzer

Description

What steps will reproduce the problem?

  1. Load a type = foot, hiking, bicycle or horse route without network tag, e.g. 3916982, 5428433, 2903220, 3533434.
  2. Execute the validator

What is the expected result?

Validator should not complain about route type

What happens instead?

Valiador gives a warning: "Relation type is unknown".

Please provide any additional information below. Attach a screenshot if possible.

The current warning is misleading (took me a while to find out what he wants). The relation type is ok, the warning should rather be something like "Network of route relation is unknown".

I am not sure if networks are manadatory or just optional or recommended (see
http://wiki.openstreetmap.org/wiki/Hiking#Tagging_walking_and_hiking_Route_Networks). But even if they are mandatory (sometimes, who decides?) the current warning is misleading.

The warning comes also if network is present but the value is not in the presets.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-04-28 12:48:16 +0200 (Thu, 28 Apr 2016)
Build-Date:2016-04-28 10:51:36
Revision:10161
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10161 en) Windows XP 32-Bit
Memory Usage: 153 MB / 989 MB (57 MB allocated, but free)
Java version: 1.7.0_80-b15, Oracle Corporation, Java HotSpot(TM) Client VM
Dataset consistency test: No problems found

Plugins:
- PicLayer (31895)
- apache-commons (31895)
- routes (31772)
- scripting (30722)

Tagging presets:
- https://josm.openstreetmap.de/josmfile?page=Presets/NewTags&zip=1

Map paint styles:
- https://josm.openstreetmap.de/josmfile?page=Styles/MTB&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface&zip=1
- https://josm.openstreetmap.de/josmfile?page=Styles/Surface-DataEntry&zip=1

Attachments (0)

Change History (3)

comment:1 Changed 3 years ago by Klumbumbus

Milestone: 16.05

comment:2 Changed 3 years ago by Klumbumbus

Milestone: 16.0516.06
Owner: changed from team to Klumbumbus
Status: newassigned

comment:3 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 10320/josm:

fix #12864 - update route relation presets: move name up, move ref and operator to optional, remove keyvalue! from network tag and add validator warning for missing network or piste:type, this also fixes confusing warning about relation type, fix key of ski route

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.