Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12863 closed enhancement (fixed)

[Patch] LayerManager implementation

Reported by: michael2402 Owned by: michael2402
Priority: normal Milestone: 16.05
Component: Core Version:
Keywords: gsoc-core, layers Cc: Don-vip, bastiK, stoecker

Description

This is the implementation of a new manager class that takes over all layer management the MapView once did.

There are new interfaces for layer listeners. All listeners fire in the EDT to make implementing UI listeners easier.

See #11838 for more information about the new layer manager.

Attachments (1)

patch-add-layer-manager.patch (100.1 KB) - added by michael2402 3 years ago.

Download all attachments as: .zip

Change History (17)

Changed 3 years ago by michael2402

comment:1 Changed 3 years ago by bastiK

Looks good!

comment:2 Changed 3 years ago by stoecker

Resolution: fixed
Status: newclosed

In 10271/josm:

GSOC core rework - LayerManager, fix #12863, by Michael Zangl

comment:3 Changed 3 years ago by stoecker

Please for new functions, classes already add the "@since xxx". We'll fill in the number when doing the checkin. It's easier to search for "@since xxx" then to check the whole code :-)

BTW LayerManagerWithActive is not really a fancy name...

comment:4 Changed 3 years ago by michael2402

I agree that the name is not good. I could not really think of a better one. If you can come up with one, feel free to change it before it is used in any plugins or other places.

We could rename LayerManagerWithActive->LayerManager and LayerManager -> BasicLayerManager - since most people will be using the one that most people will use.

The LayerManager.java file seems to be missing in the commit.

comment:5 Changed 3 years ago by stoecker

In 10273/josm:

GSOC core rework - LayerManager, see #12863, by Micheel Zangl, add missing file

comment:6 Changed 3 years ago by stoecker

LayerManagerWithActive --> MainLayerManager? One rename less. :-)

comment:7 Changed 3 years ago by stoecker

In 10274/josm:

GSOC core rework - LayerManager, see #12863, by Micheel Zangl, fix version

comment:8 in reply to:  6 Changed 3 years ago by michael2402

Replying to stoecker:

LayerManagerWithActive --> MainLayerManager? One rename less. :-)

Yes, we can do that. Can you do it or should I do a patch?

comment:9 Changed 3 years ago by Don-vip

In 10277/josm:

GSOC core rework - LayerManager, see #12863, fix checkstyle violations

comment:10 Changed 3 years ago by Don-vip

In 10278/josm:

GSOC core rework - LayerManager, see #12863, fix checkstyle violations (unit tests)

comment:11 Changed 3 years ago by Don-vip

In 10279/josm:

GSOC core rework - LayerManager, see #12863, rename LayerManagerWithActive to MainLayerManager

comment:12 Changed 3 years ago by Don-vip

Milestone: 16.0616.05

comment:13 Changed 3 years ago by Don-vip

thanks for the patch!

comment:14 Changed 3 years ago by Don-vip

In 10281/josm:

GSOC core rework - LayerManager, see #12863, restore a public method as deprecated to ease plugin update

comment:15 Changed 3 years ago by Don-vip

In 10282/josm:

GSOC core rework - LayerManager, see #12863, need a LayerManager accessor from MapView for plugins creating custom ones

comment:16 Changed 3 years ago by Don-vip

In 10295/josm:

see #12863 - fix typo

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain michael2402.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.