Unit test fails because preset has moved GIT repository (?)

[mdk]

It looks like the unit test
org.openstreetmap.josm.gui.preferences.map.TaggingPresetPreferenceTestIT.testValidityOfAvailablePresets
fails because it can't find preset icons:

ERROR: Failed to locate image 'https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_D9.png'
...
ERROR: Failed to locate image 'https://raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM/master/traffic_signs/BE/BE_F101b_FOOT_BICYCLE_HORSE.png'

but it looks like the repository has moved from
raw.githubusercontent.com/yopaseopor/traffic_signs_preset_JOSM
to
github.com/yopaseopor/traffic_signs_preset_JOSM
and also there is a little change in the Path ("blob"). You find the icons now at

https://github.com/yopaseopor/traffic_signs_preset_JOSM/blob/master/traffic_signs/BE/BE_C9.png

[stoecker]

Report this in the github project not here. The links are in the XML file, we don't invent anything additional. As the author supplies a zip, there should not be URL's in the icon fields at all, but only the names of the included icon files.

[Don-vip]

See ​https://github.com/yopaseopor/traffic_signs_style_JOSM/issues/4

[yopaseopor]

Can I supply the xml file instead of the zip file? It has +2800 icons (traffic signs) thus 25 folders (countries).

[stoecker]

Using a xml file with links is not recommended. Each link will be loaded individually and that takes time.

There are two solutions.

• The Zip variant with XML and icons icluded.
• Using "data:" URL's to include the icons in the XML file.

Zip has the advantage of compression, whereas the data URL's waste additional space due to base64 encoding and the XML itself is also uncompressed and takes longer to load.

A question - If I understand correctly you moved from JOSM wiki to GIT for size limitations? I'm not aware we have any size limitations on JOSM wiki.

[yopaseopor]

Yes, the maximum size per file or text is 2 MB (Well, I don't know exactly how it works the limits files but I had two errors of size when I had tried to "duplicate" Spain data for making Belgium before take the externalization option.

[yopaseopor]

In other way I have a big error in preset "content is not allowed in prolog" . JOSM does not tell me where is the error (in a way I can find it and fix it - number of line (for example). The error exists when I try to add any traffic sign (folder traffic_sign/BE or traffic_sign/ES - for this reason I put all of them via URL). Any idea?

[stoecker]

Your second error looks like an XML error. You can find these e.g. with xmllint or other similar tools.

Yes, we have a size limit for attachments, but that should not affect presets. In the simple case that the icon files to be attached exceed the size limit, simply attach more than one zip file with each containing a part of the icons.

[yopaseopor]

Fixed. After 51 changes I have discovered in some of the 2500+ files some non-english characters (nor in the XML file).