Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12771 closed enhancement (fixed)

Validation rules for service=*

Reported by: naoliv Owned by: team
Priority: normal Milestone: 16.05
Component: Core validator Version:
Keywords: mapcss, service Cc:

Description

As always, consider it as a proof of concept.
We have an idea to validate service=* tags:

way[highway = service][service][service !~ /^(alley|drive-through|driveway|emergency_access|parking_aisle)$/],
way[railway = rail][service][service !~ /^(crossover|siding|spur|yard)$/],
way[waterway = canal][service][service !~ /^(irrigation|transportation|water_power)$/] {
        throwWarning: tr("wrong or unknown service type");
}

And also warn for unspecific service=yes (1778 objects):

*[service = yes] {
        throwWarning: tr("unspecific value for key service");
}

Also, I know that somewhere in JOSM there is a mechanism to fix tags with typos.
I guess it could be used to fix the wrong service=drive_through (910 objects in taginfo) → service=drive-through (37207)

There is a case where it's necessary to evaluate if a test is necessary:

749 service=living_street in Eurasia: http://overpass-turbo.eu/s/fMv
Most probably they should all be highway=living_street instead highway=service + service=living_street

Attachments (0)

Change History (5)

comment:1 in reply to:  description Changed 3 years ago by Klumbumbus

Replying to naoliv:

Also, I know that somewhere in JOSM there is a mechanism to fix tags with typos.
I guess it could be used to fix the wrong service=drive_through (910 objects in taginfo) → service=drive-through (37207)

Here https://josm.openstreetmap.de/browser/josm/trunk/data/validator/words.cfg, however this is only for keys as far as I know.

comment:2 Changed 3 years ago by Klumbumbus

In 10229/josm:

see #12771 - warn about service=yes; warn about service=drive_through (replace by drive-through)

comment:3 Changed 3 years ago by Klumbumbus

In 10230/josm:

see #12771 - warn about uncommon values of key service

comment:4 Changed 3 years ago by Klumbumbus

Keywords: service added
Milestone: 16.05
Resolution: fixed
Status: newclosed

comment:5 Changed 3 years ago by Klumbumbus

In 10249/josm:

see #12771 - adjust service validator warning (don't warn twice for the same error)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.