Modify

Opened 8 years ago

Closed 8 years ago

#12757 closed enhancement (fixed)

add presets for trail riding stations

Reported by: Hufkratzer Owned by: team
Priority: normal Milestone:
Component: External preset Version:
Keywords: trail_riding_station Cc: Hufkratzer

Description

What steps will reproduce the problem?

search for preset for trail riding station as described in http://wiki.openstreetmap.org/wiki/Riding

What is the expected result?

found

What happens instead?

not found

Please provide any additional information below. Attach a screenshot if possible.

Please add presets for trail riding stattions.

I have attached a proposal in form of an extended defaultpresets.xml based on the latest development version 10144. The diff looks like this:

3528a3528
>             <check key="trail_riding_station" text="Trail riding station" />            
3550a3551
>             <check key="trail_riding_station" text="Trail riding station" />
3571a3573
>             <check key="trail_riding_station" text="Trail riding station" />
3577a3580,3588
>         <item name="Trail Riding Station" icon="presets/equestrian.png" type="node,closedway,multipolygon" preset_name_label="true">
>             <link href="http://wiki.openstreetmap.org/wiki/Riding" 
>             	de.href="http://wiki.openstreetmap.org/wiki/DE:Riding" />
>             <space />
>             <key key="tourism" value="trail_riding_station" />
>             <reference ref="name_operator" />
>             <space />
>             <reference ref="link_contact_address_payment" />
>         </item> <!-- Trail Riding Station -->
3593a3605
>             <check key="trail_riding_station" text="Trail riding station" />
3615a3628
>             <check key="trail_riding_station" text="Trail riding station" />
3635a3649
>             <check key="trail_riding_station" text="Trail riding station" />
3657a3672
>             <check key="trail_riding_station" text="Trail riding station" />
3681a3697
>             <check key="trail_riding_station" text="Trail riding station" />
3702a3719
>             <check key="trail_riding_station" text="Trail riding station" />

This means there are some additions in the accommodation group, namely a new item "Trail Riding Station" and additional checkboxes in the other items in this group because there one needs to use trail_riding_station=yes instead of tourism=trail_riding_station.

I think horse=yes (as described in the wiki) is dispensable (as is foot=yes at every hotel), if you think it is not the proposal may be improved.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2016-04-13 22:58:11 +0200 (Wed, 13 Apr 2016)
Build-Date:2016-04-14 01:33:34
Revision:10144
Relative:URL: ^/trunk

Identification: JOSM/1.5 (10144 en) Windows XP 32-Bit
Memory Usage: 97 MB / 247 MB (38 MB allocated, but free)
Java version: 1.7.0_80-b15, Oracle Corporation, Java HotSpot(TM) Client VM

Plugins:
- PicLayer (31895)
- apache-commons (31895)
- routes (31772)
- scripting (30722)

Tagging presets:
- D:\Installer\XP\GPS\JOSM\horse_presets_10144.xml

Last errors/warnings:
- W: Update plugins - org.openstreetmap.josm.plugins.PluginHandler$UpdatePluginsMessagePanel[,0,0,0x0,invalid,layout=java.awt.GridBagLayout,alignmentX=0.0,alignmentY=0.0,border=,flags=9,maximumSize=,minimumSize=,preferredSize=]

Attachments (3)

trail_riding_presets_10144.xml (706.4 KB ) - added by Hufkratzer 8 years ago.
extended defaultpresets.xml
v68.jpg (39.1 KB ) - added by Hufkratzer 8 years ago.
updated presets menu
missing_trail_riding_station.jpg (16.3 KB ) - added by Hufkratzer 8 years ago.
but no trail riding station appears

Download all attachments as: .zip

Change History (8)

by Hufkratzer, 8 years ago

extended defaultpresets.xml

comment:1 by Klumbumbus, 8 years ago

See our Preset guidelines
tourism=trail_riding_station has only 341 uses. Nearly all of them are in germany (and a big amount from user Shiega). Its wikipage is empty. So this tag is not ready for inclusion in the default preset. However you can add it to Presets/NewTags.

trail_riding_station=yes is used only 4 times. This tag is not appropriate for a preset.

comment:2 by Klumbumbus, 8 years ago

Summary: add presets for trail riding stattionsadd presets for trail riding stations

by Hufkratzer, 8 years ago

Attachment: v68.jpg added

updated presets menu

by Hufkratzer, 8 years ago

but no trail riding station appears

in reply to:  1 comment:3 by Hufkratzer, 8 years ago

Replying to Klumbumbus:

... However you can add it to Presets/NewTags.

This is done (wiki page version 68) and if I download the xml file from the wikipage and use this external file in JOSM it works. But if I try to use the wikipage directly over the web it does not work, see new attachments (screenshots). I can't find the reason. Please check this.

comment:5 by Klumbumbus, 8 years ago

Component: Internal presetExternal preset
Resolution: fixed
Status: newclosed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.