Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12680 closed enhancement (fixed)

[Patch] Documentation and cleanup on predicates

Reported by: michael2402 Owned by: team
Priority: minor Milestone: 16.04
Component: Core Version:
Keywords: predicate Cc:

Description

  • Added new always true and always false predicates.
  • Merged duplicate code of direction keys.
  • New Predicate: isOfClass - used in OsmPrimitive
  • Added javadoc

Attachments (1)

patch-osm-primitive-predicates.patch (12.5 KB) - added by michael2402 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by michael2402

comment:1 Changed 4 years ago by Don-vip

Milestone: 16.03

comment:2 Changed 4 years ago by Don-vip

shouldn't we use constants instead? ALWAYS_TRUE and ALWAYS_FALSE?

comment:3 Changed 4 years ago by michael2402

The methods are not used often - at most once when creating a query.

If we add those constants we should add them as private members. We need to have a method to get nice generics (same reason Collections has all those methods to access the constants).

comment:4 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 10040/josm:

fix #12680 - Documentation and cleanup on predicates (patch by michael2402, modified)

comment:5 Changed 4 years ago by Don-vip

Milestone: 16.0316.04

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.