Improve the josm-plugins git mirror

[kolesar]

Build errors were thrown for ant or even ant clean commands in the plugins directory. There were several directories listed in build.xml that do not exist in the repository. Removed corresponding lines from xml.

[simon04]

Those plugin directories are provided by svn:externals, see at the bottom of ​https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins

[kolesar]

Replying to simon04:

Those plugin directories are provided by svn:externals, see at the bottom of ​https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins

Sorry. I have checked out plugins from git mirror where these directories did not exist.

I added these four plugins with git submodule command but ant still failed because there are many more externals deeper in the tree. I have given up and checked out from svn.

[bastiK]

Should be reported to the maintainer of that mirror, so they can activate the same system as used for the JOSM mirror.

[simon04]

I run the JOSM mirror ;) → ​https://github.com/simon04/josm-mirror

Not a single external repository is fetched for the plugins – that's why it's an inofficial one …

Improvements to get a simpler/robuster/better mirroring process are very welcome

[bastiK]

Good to know! :)

[kolesar]

Replying to simon04:

Improvements to get a simpler/robuster/better mirroring process are very welcome

Could you please include externals into plugins mirror git repository? I have just sumbitted a pull request to ​https://github.com/simon04/josm-mirror.

Before I realized that some plugins have externals I tried to build plugins by adding missing four plugins manually. I had additional build failures:

• Build have failed because svn reported an error when asked for commit date. It works only if working directory was checked out from svn. JOSM core has a nice solution for this situation: if svn reports failure then asks git for commits. Plugins did have the same algorithm in build-common.xml but some plugins used the svn-only method, did not include new one from common location. Applied the same for plugins where it was needed.

• Some plugins relied on empty directories that were checked out by svn but not by git, usually named resources. Added mkdir commands where it was needed.

Attached patch that will be needed to build plugins successfully from git mirror.

[simon04]

Thanks for your patch. Obsolete due to [o32306].