Modify

Opened 5 years ago

Closed 11 months ago

#12399 closed enhancement (fixed)

Improve the josm-plugins git mirror

Reported by: kolesar Owned by: team
Priority: normal Milestone:
Component: Git mirror Version:
Keywords: Cc:

Description

Build errors were thrown for ant or even ant clean commands in the plugins directory. There were several directories listed in build.xml that do not exist in the repository. Removed corresponding lines from xml.

Attachments (2)

RemovedMissingDirectories.plugins.patch (2.6 KB) - added by kolesar 5 years ago.
FixGitBuild.patch (22.1 KB) - added by kolesar 5 years ago.

Download all attachments as: .zip

Change History (10)

Changed 5 years ago by kolesar

comment:1 Changed 5 years ago by simon04

Resolution: invalid
Status: newclosed

Those plugin directories are provided by svn:externals, see at the bottom of https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins

comment:2 in reply to:  1 Changed 5 years ago by kolesar

Replying to simon04:

Those plugin directories are provided by svn:externals, see at the bottom of https://trac.openstreetmap.org/browser/subversion/applications/editors/josm/plugins

Sorry. I have checked out plugins from git mirror where these directories did not exist.

I added these four plugins with git submodule command but ant still failed because there are many more externals deeper in the tree. I have given up and checked out from svn.

comment:3 Changed 5 years ago by bastiK

Should be reported to the maintainer of that mirror, so they can activate the same system as used for the JOSM mirror.

comment:4 Changed 5 years ago by simon04

Resolution: invalid
Status: closedreopened
Summary: [patch] removed missing directories from build.xmlImprove the josm-plugins git mirror
Type: defectenhancement

I run the JOSM mirror ;) → https://github.com/simon04/josm-mirror

Not a single external repository is fetched for the plugins – that's why it's an inofficial one …

Improvements to get a simpler/robuster/better mirroring process are very welcome

comment:5 Changed 5 years ago by bastiK

Good to know! :)

comment:6 in reply to:  4 Changed 5 years ago by kolesar

Replying to simon04:

Improvements to get a simpler/robuster/better mirroring process are very welcome

Could you please include externals into plugins mirror git repository? I have just sumbitted a pull request to https://github.com/simon04/josm-mirror.

Before I realized that some plugins have externals I tried to build plugins by adding missing four plugins manually. I had additional build failures:

  • Build have failed because svn reported an error when asked for commit date. It works only if working directory was checked out from svn. JOSM core has a nice solution for this situation: if svn reports failure then asks git for commits. Plugins did have the same algorithm in build-common.xml but some plugins used the svn-only method, did not include new one from common location. Applied the same for plugins where it was needed.
  • Some plugins relied on empty directories that were checked out by svn but not by git, usually named resources. Added mkdir commands where it was needed.

Attached patch that will be needed to build plugins successfully from git mirror.

Changed 5 years ago by kolesar

Attachment: FixGitBuild.patch added

comment:7 Changed 3 years ago by Don-vip

Component: PluginGit mirror

comment:8 Changed 11 months ago by simon04

Resolution: fixed
Status: reopenedclosed

Thanks for your patch. Obsolete due to [o32306].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.