Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12393 closed defect (fixed)

[patch] Fix parsing note hiding events

Reported by: ToeBee Owned by: Don-vip
Priority: normal Milestone: 16.02
Component: Core notes Version: tested
Keywords: hidden Cc:

Description (last modified by Don-vip)

I just tried to open up the latest planet note dump and hit an exception while parsing. The problem was with this note: http://www.openstreetmap.org/note/233775

It was mistakenly hidden which generated a comment element with a "hidden" action which JOSM doesn't know about. Interestingly, there is no unhide comment, just a reopen. The full note XML looks like this:

<note id="233775" lat="48.2411985" lon="-122.3744820" created_at="2014-08-31T17:13:29Z" closed_at="2015-09-06T23:35:14Z">
  <comment action="opened" timestamp="2014-08-31T17:13:29Z" uid="7247" user="goldfndr">Jump Start Espresso | 26930</comment>
  <comment action="hidden" timestamp="2015-09-06T23:34:26Z" uid="355617" user="pnorman"></comment>
  <comment action="reopened" timestamp="2015-09-06T23:34:38Z" uid="355617" user="pnorman"></comment>
  <comment action="closed" timestamp="2015-09-06T23:35:14Z" uid="355617" user="pnorman">mapped, but inadvertently hid the note</comment>
</note>

Anyway, here is a patch to add the "hidden" option to the enum in NoteComment.java

Attachments (1)

hidden_note.patch (423 bytes) - added by ToeBee 4 years ago.

Download all attachments as: .zip

Change History (6)

Changed 4 years ago by ToeBee

Attachment: hidden_note.patch added

comment:1 Changed 4 years ago by Don-vip

Keywords: hidden added; notes removed

comment:2 Changed 4 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 4 years ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned

comment:4 Changed 4 years ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 9569/josm:

fix #12393 - Fix parsing note hiding events (patch by ToeBee) + add non-regression unit test

comment:5 Changed 4 years ago by Don-vip

thanks! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.