Opened 10 years ago
Closed 10 years ago
#12392 closed enhancement (fixed)
[patch] default filename when saving layer
| Reported by: | kolesar | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 16.02 |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description (last modified by )
Use case: create a new data layer, rename it and save as a file. Current JOSM pops up save as dialog with empty filename. Patched version fills default filename with name of the layer if user has renamed that. If layer was not renamed and does not have an associated file (= is called Data layer n) then filename is empty. If layer has associated filename then it is displayed.
Requires patch #12391 that keeps track if layer was renamed by the user. Also requires #12394 that fixes NativeFileChooser.
Refactored telescopic contructors in FileChooserManager to builder pattern to be able to add new settings.
Attachments (2)
Change History (9)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 10 years ago
by , 10 years ago
| Attachment: | DefaultFilenameForRenamedLayer.patch added |
|---|
comment:5 by , 10 years ago
| Milestone: | → 16.02 |
|---|
comment:6 by , 10 years ago
| Resolution: | fixed |
|---|---|
| Status: | closed → reopened |
I have made a mistake in this patch. I have forgot to set allTypes parameter in FileChooserManager when saving OsmDatalayer. Only uncompressed .osm file format was selectable in non-native file chooser.
Attached fix.
by , 10 years ago
| Attachment: | DefaultFilenameForRenamedLayer.fix.patch added |
|---|



Replying to kolesar:
This is good, but please add javadoc for public methods.