Modify

Opened 3 years ago

Closed 3 years ago

#12337 closed enhancement (fixed)

add support for shop=tobacco

Reported by: dieterdreist Owned by: team
Priority: normal Milestone: 16.02
Component: Internal preset Version:
Keywords: tobacco, shop Cc: zermes

Description

the tag is currently used 4444 times and it is documented in the wiki.

Attachments (1)

tobacco-pipe.svg (2.9 KB) - added by dieterdreist 3 years ago.
tobacco pipe to be used for shop=tobacco. License cc0, created by Martin Koppenhoefer

Download all attachments as: .zip

Change History (11)

comment:1 Changed 3 years ago by dieterdreist

if needed I can provide an icon.

comment:2 in reply to:  1 Changed 3 years ago by Klumbumbus

Component: CoreInternal preset
Milestone: 16.02

Replying to dieterdreist:

if needed I can provide an icon.

Yes, please in svg.

comment:3 Changed 3 years ago by Don-vip

Cc: zermes added

black & white icons are not great for JOSM because of our black background. zermes, any idea? :)

comment:4 Changed 3 years ago by dieterdreist

yes, I didn't mean this literally, I drew the shape template so you can change the colour to any colour that integrates well with the other shop icons. If you tell me the colour code I can do it if you prefer this. There is no white in the icon, just one colour. Or if a border is desired. You can also point me to a link to another svg shop icon so I can copy these things from there.

Last edited 3 years ago by dieterdreist (previous) (diff)

comment:5 Changed 3 years ago by Klumbumbus

There is no color code for shop icons. Just make sure that the icon is visible atleast on black, white and grey background.
We cannot use cc-by icons, because cc-by is not compatible with GPL.

more icon guidlines: https://josm.openstreetmap.de/wiki/DevelopersGuide/DefaultPresets#NewIcons

Changed 3 years ago by dieterdreist

Attachment: tobacco-pipe.svg added

tobacco pipe to be used for shop=tobacco. License cc0, created by Martin Koppenhoefer

comment:6 Changed 3 years ago by dieterdreist

thank you for the hints, I have now replaced the icon with a (hopefully correctly formated) updated version and changed the license to cc0.

comment:7 Changed 3 years ago by Klumbumbus

Thanks. I'm unsure in which group this belongs: "For the body" or "Other"?
...or "Food" ;)

comment:8 Changed 3 years ago by dieterdreist

yes, "For the body" seems a good fit, maybe you should also move the funeral directors from "other" to this category ;-)

comment:9 Changed 3 years ago by dieterdreist

btw.: I'm unsure if I have used the correct width and height, I made this now 100% and the viewBox as suggested 0 0 16 16, if it doesn't work like this it must be 16 width and height.

comment:10 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 9420/josm:

fix #12337 - add shop=tobacco to preset and mappaint style, icon (by Martin Koppenhoefer) see [o31978]

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.