Modify ↓

Opened 7 years ago

Closed 7 years ago

#12322 closed enhancement (fixed)

[patch] GeoImageLayer: Add method isCenterView() to ImageViewerDialog

Reported by: holgermappt Owned by: team
Priority: normal Milestone: 16.02
Component: Core image mapping Version:
Keywords: Cc:

Description

This patch adds the public method isCenterView() to class ImageViewerDialog. It is needed for the PhotoAdjust plugin to disable the center view button only if it is selected.

Please note that the button uses British English (tbCentre) while the state variable uses American English (centerView). Would it make sense to use the same spelling for both? What is the preferred language variant anyway?

Is there something like a "golden" source code file that complies to the JOSM coding guidelines? I see many different styles, somethimes even in the same file. It would be good to have a reference which style to use.

Attachments (1)

GeoImageLayer_isCenterView.patch​ (810 bytes) - added by holgermappt 7 years ago.

Download all attachments as: .zip

Change History (3)

Changed 7 years ago by holgermappt

Attachment: GeoImageLayer_isCenterView.patch​ added

comment:1 Changed 7 years ago by Don-vip

Milestone: → 16.02

comment:2 Changed 7 years ago by Don-vip

Resolution: → fixed
Status: new → closed

In 9416/josm:

fix #12322 - GeoImageLayer: Add method isCenterView() to ImageViewerDialog (patch by holgermappt)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.