Modify

Opened 3 years ago

Last modified 3 years ago

#12310 new enhancement

Validator: add "gap between buildings"

Reported by: MKnight Owned by: team
Priority: normal Milestone:
Component: Core validator Version:
Keywords: template_report building gap osmose Cc:

Attachments (1)

Touching Buildings.osm (1.5 KB) - added by mdk 3 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 3 years ago by Don-vip

Keywords: building gap osmose added
Version: tested

comment:2 Changed 3 years ago by Aun Johnsen <lists@…>

Lack of gap between buildings is not necessarily wrong (for example where I live, the outer wall of my house is part of the outer wall of my neighbour to the right, and the neighbour to the left), overlapping buildings on the other hand is most likely wrong. Another thing I have seen at times are buildings inside buildings, which are most definitely wrong.

comment:3 Changed 3 years ago by MKnight

Aun: you are right, that that not _must_ be wrong, but it can be wrong (in most of the times is it) I think this check can be in the category "other" (not warnings).

you can give osmose a try for that, 95% of gap-errors there are wrong on the ground/map.

Dont understand your example, if "your" buildings are connected, then they have to be connected on the map too with no gap.

buildings inside buildings are wrong, yes, feel free to add an own feature request for that.

comment:4 Changed 3 years ago by Aun Johnsen <lists@…>

MKnight: I have mapped my house and the neighbouring as accurate as possible, where they are visibly connected they are mapped sharing the same nodes, etc.

I agree that a check can be made to the validator, but put it rather in "information" than "warning" or "error", as my example are quite common, at least in denser cities.

On the other hand, it might be valid to explore (i.e. on the tagging@ mailing list) if it is wise to tag these buildings as individual polygons, or if rather a multi-polygon relation is on its place, though the validator should not give precedence in this until a decision in made from the community.

comment:5 Changed 3 years ago by Aun Johnsen <lists@…>

I think building inside building already are warned about.

comment:6 Changed 3 years ago by MKnight

i have checked the building inside building before my answer. (no warning) Maybe its broken since new josm-release. Will check that later.

Last edited 3 years ago by MKnight (previous) (diff)

comment:7 Changed 3 years ago by Aun Johnsen <lists@…>

It is possible that the check is from an additional validator (external), I have a few external validators loaded.

comment:8 Changed 3 years ago by MKnight

have checked building in building with older versions, no warnings. Do you want to open a new ticket for that?

P.s. (want to write me at https://www.openstreetmap.org/message/new/MKnight what (and how) external tools you use?)

Last edited 3 years ago by MKnight (previous) (diff)

comment:9 Changed 3 years ago by Klumbumbus

The building inside building warning works as expected. You need to activate "geometry" in the validator tag checker settings.

comment:10 in reply to:  9 Changed 3 years ago by MKnight

Replying to Klumbumbus:

The building inside building warning works as expected. You need to activate "geometry" in the validator tag checker settings.

Klumbumbus: thx, dunno why that was not activated here.

Changed 3 years ago by mdk

Attachment: Touching Buildings.osm added

comment:11 Changed 3 years ago by mdk

I think a gap between buildings is possible (normally wide enough that a huuman can pass).

But I found often buildings which only has one node together (see attachment). I have never seen two buildings which touch only in one point and habe a acute angle.

comment:12 Changed 3 years ago by mdk

@MKnight: Can you append an example file where you expect a validator warning? Or is the ticket not longer relevant?

comment:14 Changed 3 years ago by MKnight

Not good examples?

Modify Ticket

Change Properties
Set your email in Preferences
Action
as new The owner will remain team.
as The resolution will be set.
to The owner will be changed from team to the specified user.
The owner will change to MKnight
as duplicate The resolution will be set to duplicate.The specified ticket will be cross-referenced with this ticket
The owner will be changed from team to anonymous.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.