Modify

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#12232 closed enhancement (fixed)

New preset icons in svg - railway and ways - and a new tag railway=traverser

Reported by: zermes Owned by: Klumbumbus
Priority: normal Milestone: 16.01
Component: Internal preset Version:
Keywords: icon svg preset railway abandoned rail buffer stop bus guideway crossing disused level crossing light rail millestone monorail narrow gauge preserved signal subway switch tram turntable traverser transfer table way combined foot cycleway cycle lane track dedicated bridleway footway path segregated steps track Cc: Klumbumbus, Nakaner

Description

A few more to add. One of them doesn't exist in JOSM presets. It's the railway=traverser taginfo or transfer_table taginfo. wikipedia Can we add it to JOSM? Since JOSM have turntable I think it should have this one too. It is more used today than the roundtable that was used more in the steam locomotive era, I think.

I took off the line in the middle of "Combined Foot and Cycleway" sign because that line doesn't make sense, at the same time, keeps the sign recognizable and is more easy to distinguish it from the segregated sign in the tool bar menu without the text.

In the steps icon I've made another approach, removed the blue background from the official sign since it can be used in all steps, most of them don't have that sign. The other blue signs, most of the time, must have those signs in the field if we want to tag something with those tags (although unfortunately they are not blue in every country).

All released in CC0 and/or public domain. Some of them were based in openclipart.org and wikimedia.org signs (I was careful, took only the ones in public domain, some signs in wikimedia are not in public domain like CC-BY-SA and others).

Attachments (7)

JOSM_icons_railway_and_ways.png (14.8 KB) - added by zermes 3 years ago.
JOSM_svg_icons_railway_and ways.7z (12.0 KB) - added by zermes 3 years ago.
JOSM_svg_icons_railway_and ways_viewBox_Fixed.7z (12.0 KB) - added by zermes 3 years ago.
JOSM_icons_railway_and_ways_v2.png (10.8 KB) - added by zermes 3 years ago.
JOSM_svg_icons_railway_and ways_v2.7z (13.3 KB) - added by zermes 3 years ago.
crossings.png (61.7 KB) - added by Klumbumbus 3 years ago.
crossings2.png (59.4 KB) - added by Klumbumbus 3 years ago.

Download all attachments as: .zip

Change History (35)

Changed 3 years ago by zermes

Changed 3 years ago by zermes

comment:1 Changed 3 years ago by zermes

Here is a preview:

comment:2 Changed 3 years ago by Klumbumbus

Cc: Klumbumbus added

comment:3 Changed 3 years ago by Klumbumbus

Component: CoreInternal preset

comment:4 Changed 3 years ago by zermes

SVG files with viewBox values fixed.

comment:5 Changed 3 years ago by zermes

If the missing tag railway=traverser is added to JOSM use the help page created a few moments ago https://wiki.openstreetmap.org/wiki/Tag:railway%3Dtraverser

comment:6 in reply to:  5 Changed 3 years ago by Don-vip

Replying to zermes:

If the missing tag railway=traverser is added to JOSM use the help page created a few moments ago https://wiki.openstreetmap.org/wiki/Tag:railway%3Dtraverser

I see a very low usage of this tag yet (115 is generally not enough to be included in JOSM default presets). Does it mean that most of traversers are currently tagged as turntables?

comment:7 Changed 3 years ago by zermes

Probably no one use the tag roundtable in a transverser since they have very different layouts (circle vs rectangle). The first time I saw one I used the tag "name=Transfer table" (of course is not the correct tag, It was a long time ago, I was learning) and "wikipedia=en:Transfer table".

I just thought if JOSM has roundtable it should have traverser, because they are a little similar. But I understand if we add a lot of tags to JOSM (railway has a lot not documented), it becomes a mess. Anyway we can add it latter if is used more. A least now it has the wiki page to help people find the correct tag.

Now the other icons are good in JOSM :-) Thanks.

comment:8 Changed 3 years ago by Klumbumbus

Milestone: 16.01

comment:9 Changed 3 years ago by zermes

Please don't put these icons in JOSM now. I will make some changes to them. They must work in dark or grey themes as we can see in https://josm.openstreetmap.de/ticket/12259#comment:6

Changed 3 years ago by zermes

Changed 3 years ago by zermes

comment:10 Changed 3 years ago by zermes

Here they are. Released under CC0/Public Domain.


comment:11 Changed 3 years ago by zermes

Keywords: railway abandoned rail buffer stop bus guideway crossing disused level crossing light rail millestone monorail narrow gauge preserved signal subway switch tram turntable traverser transfer table way combined foot cycleway cycle lane track dedicated bridleway footway path segregated steps track added

comment:12 Changed 3 years ago by Klumbumbus

I would add the new icons now, but keep the old ones for now, to not break external presets. In next milestone we can remove the old icons and adjust external presets. Any concerns?

comment:13 Changed 3 years ago by Don-vip

OK to add new icons now, sounds good. Have you checked the presets for the pharmacy icons ? There was failures yesterday.

comment:14 Changed 3 years ago by Klumbumbus

Yes I fixed them. However there is still one error, but I don't know where it comes from. There is no preset with "KO" in the list. All have "OK". https://josm.openstreetmap.de/jenkins/job/JOSM/585/jdk=JDK8/testReport/junit/org.openstreetmap.josm.gui.preferences.map/TaggingPresetPreferenceTest/testValidityOfAvailablePresets/

comment:15 Changed 3 years ago by Klumbumbus

Owner: changed from team to Klumbumbus
Status: newassigned

comment:16 Changed 3 years ago by Klumbumbus

Resolution: fixed
Status: assignedclosed

In 9306/josm:

fix #12232 - Add new railway and way icons, by zermes (CC0/PD), icons see [o31936]; drop steps mappaint icon

comment:17 Changed 3 years ago by simon04

In 9307/josm:

see #12232 - Fix XML (duplicate attribute)

comment:18 in reply to:  14 Changed 3 years ago by Don-vip

Replying to Klumbumbus:

Yes I fixed them. However there is still one error, but I don't know where it comes from. There is no preset with "KO" in the list. All have "OK".

That's very strange. When I run the test on my machine I got the erroneous test:

http://michreichert.de/osm/wochenaufgabe/wa0607-apotheken/apotheken.xml
INFO: GET http://michreichert.de/osm/wochenaufgabe/wa0607-apotheken/apotheken.xml -> 200 (3.38 kB)
ERROR: Failed to locate image 'styles/standard/health/pharmacy.png'
WARNING: [NODE, CLOSEDWAY] Pharmacy: Could not get presets icon styles/standard/health/pharmacy.png
 => KO

Does anyone know Michael Reichert to let him know he must update the icon?

comment:19 Changed 3 years ago by Klumbumbus

Cc: Nakaner added

Michael,can you please update your preset. Or can we delete it, since the internal pharmacy preset was enhanced meanwhile?

comment:20 Changed 3 years ago by Nakaner

@Klumbumbus You can delete the preset. It was just used during a Wochenaufgabe in 2015.

comment:21 in reply to:  20 Changed 3 years ago by Don-vip

Replying to Nakaner:

You can delete the preset. It was just used during a Wochenaufgabe in 2015.

Done. Thank you! :)

comment:22 Changed 3 years ago by Klumbumbus

The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)


Location: https://www.openstreetmap.org/#map=19/50.83503/12.92419

Last edited 3 years ago by Klumbumbus (previous) (diff)

Changed 3 years ago by Klumbumbus

Attachment: crossings.png added

Changed 3 years ago by Klumbumbus

Attachment: crossings2.png added

comment:23 in reply to:  22 Changed 3 years ago by Nakaner

Replying to Klumbumbus:

The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)

Semi-OT: If a footway crosses a tram track, railway=* is right and highway=* is wrong. People argue if railway=crossing or railway=level_crossing is better.

comment:24 Changed 3 years ago by Nakaner

I prefer the old icons over the new ones. If want to get away from the German saltire, you might have a look at the crossing icons of OpenRailwayMap. https://github.com/rurseekatze/OpenRailwayMap/blob/master/styles/icons/crossing.svg https://github.com/rurseekatze/OpenRailwayMap/blob/master/styles/icons/level-crossing.svg

These icons were designed and committed by myself and I hereby allow the JOSM developers to distribute them under any license (i.e. CC-0).

comment:25 Changed 3 years ago by Klumbumbus

In 9421/josm:

see #12232 - move old icons to nodist folder; see also [o31979]

comment:26 Changed 3 years ago by Klumbumbus

In 9424/josm:

see #12232 - move icon, which is still in use in internal preset back from nodist folder

comment:27 in reply to:  22 ; Changed 3 years ago by zermes

Replying to Klumbumbus:

The new railway crossing icons are a bit obtrusive. This was better before. (However I'm not sure, if the usage on tram crossings is correct.)

I didn't forgot this. I will try other icons but won't be easy (if it was I would have already done it). In fact these obtrusive icons weren't easy too, believe me, before these I tried others that I don't have courage to show here, they were very very terrible.

Replying to Nakaner:

I prefer the old icons over the new ones. If want to get away from the German saltire(...)

I don't have nothing against "German saltire" per se, it's just too much abstract. If a 10 year old kid can figure out what a icons means, I think it's one proof the icon works, and I think that it's not the case in the previous icons.

comment:28 in reply to:  27 Changed 3 years ago by Klumbumbus

Replying to zermes:

If a 10 year old kid can figure out what a icons means, I think it's one proof the icon works, and I think that it's not the case in the previous icons.

To me it was not so clear what the black and brown parts in your crossing icons mean. The context with the rail icon helped me to understand. However to understand what such an icon means is less important in this case because you will understand very fast any icon. And then it is more important that the icon is not obtrusive.

I checked the levelcrossing wikipedia pages and wikimedia commons and it seems, that a red cross (in different variations) is used in most countries. So I replaced the icons with two new svg icons, which a very similar to the old ones. See [o32032].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Klumbumbus.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.