The components of Conflation Plugin's settings dialog are misaligned

[coso]

The components of Conflation Plugin's settings dialog are misaligned.

I provided a patch as pull request ​here that does the following changes:

• align components to the left and add regular spaces among them
• add a "Layer:" label to explain the meaning of "(none)" string
• add icons to buttons
• translate the strings with the numbers of selected objects
• fix typo: "subject" --> "reference" in SettingsDialog.java#L215

See the pull request for before/after screenshot.

URL:http://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2015-11-24 00:04:12 +0100 (Tue, 24 Nov 2015)
Build-Date:2015-11-23 23:14:21
Revision:9060
Relative:URL: ^/trunk

Identification: JOSM/1.5 (9060 it) Linux Ubuntu 15.10
Memory Usage: 329 MB / 876 MB (258 MB allocated, but free)
Java version: 1.8.0_66-internal, Oracle Corporation, OpenJDK 64-Bit Server VM
VM arguments: [-Djosm.restart=true, -Djava.net.useSystemProxies=true]

Plugins:
- conflation (0.1.9)
- jts (31772)
- utilsplugin2 (31772)

[coso]

I have a question.
I though to report the pull request here too, just for the records, but maybe this wasn't necessary.
Should I create a ticket the next time I propose a pull request or add an issue about a plugin in JOSM organization on GitHub?

[wiktorn]

This should be not necessary, as the pull request should be handled by the maintainer and as a part of this process, he should be able to update repository with new *jar file.

[Don-vip]

thanks for the PR, I have merged it :)

I see conflation plugin is using a COTS: MigLayout. It is only used one time in MatchFinderPanel. I don't think the use of this COTS is justified and I'd like to see it removed, would you be interested to help us to do that in a new PR?

[coso]

@wiktor
Thanks.

@Don-vip
Thank you for merging.
\o/ My first code contribution to JOSM (almost) :-)

I'm new to Java but it doesn't seem difficult to remove MigLayout. I'll take a look at that.

[Don-vip]

MigLayout removed with ​https://github.com/JOSM/josm-conflation-plugin/pull/2 thanks! :)