#12110 closed defect (fixed)
wrong translation of relation "description" in Selection and Relation toggle dialog
| Reported by: | naoliv | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.11 |
| Component: | Core | Version: | |
| Keywords: | i18n | Cc: |
Description (last modified by )
I was seeing that natural=wood multipolygons are translated as madeira in Portuguese (which is wrong for this case; it has a different meaning).
Looking at Launchpad I saw only one place where we can translate wood:
Since there isn't any other string translated as madeira, I guess that JOSM is also taking natural=wood from this same translation.
Another translation for wood (when used as natural=wood) is needed.
Attachments (2)
Change History (12)
comment:1 by , 9 years ago
by , 9 years ago
| Attachment: | floresta.png added |
|---|
comment:2 by , 9 years ago
| Resolution: | → invalid |
|---|---|
| Status: | new → closed |
comment:3 by , 9 years ago
| Resolution: | invalid |
|---|---|
| Status: | closed → reopened |
Ah, now I see that it is different for multipolygons.
comment:4 by , 9 years ago
The problem is with relations.
I don't know if you can export LC_ALL=pt_BR and run JOSM, but I see this:
This "madeira" is coming from nowhere or from the translation that I sent on the first message :-)
comment:5 by , 9 years ago
| Description: | modified (diff) |
|---|---|
| Summary: | Missing translation for "natural=wood" in pt_BR → wrong translation of relation "description" in Selection and Relation toggle dialog |
The problem is that JOSM displays there the value of one tag (I don't know the rules, which tag to choose), in this case the value of the key "natural" and translates it if a translation is availble. Since the wood in natural=wood is written with lower case letter, the wrong translation is used.
by , 9 years ago
| Attachment: | relation.png added |
|---|
comment:6 by , 9 years ago
| Keywords: | i18n added |
|---|---|
| Milestone: | → 15.11 |
comment:7 by , 9 years ago
| Description: | modified (diff) |
|---|
comment:8 by , 9 years ago
| Resolution: | → fixed |
|---|---|
| Status: | reopened → closed |
The code for this is in DefaultNameFormatter.java. We are using a lazy translation here. That means a context is used when existing, otherwise a text without context is used.
We have a list of exceptions like these relation names in specialmessages.java in main SVN i18n directory.
I added natural=wood in [o31771]. Feel free to add some other common types where necessary. Relations are used much more than at the time of implementing this.
comment:9 by , 9 years ago
So, now after [o31771] there is one more string to translate in Launchpad, which is used for the relation?
The string for the preset item "natural=wood" is "Wood" (with capital letter).
The string is https://translations.launchpad.net/josm/trunk/+pots/josm/pt_BR/6545/+translate , which is translated with "Floresta" and this is also what JOSM displays.