Opened 5 years ago

Last modified 6 months ago

#12102 closed enhancement

Popular tags not in internal presets — at Version 30

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 15.11
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by Don-vip)

I have built the list of popular tags (as defined by taginfo), unknown from JOSM presets, for which we do not have a MapCSS deprecation warning.

We should decide which tags should be added to presets, which ones should be deprecated and which ones should be ignored by the tag/key not in presets validator test. The decision that a tag is ignored is not forever and can of course be reconsidered later.

Tag (wiki) Count (taginfo) Decision
abandoned=yes 19932 Ignored. Lifecycle
amenity=swimming_pool 46883 Ignored. Duplicate of leisure=swimming_pool. However not declared as deprecated in the wiki.
bicycle=dismount 37307 Ignored for now, see #9158
bin=yes 22245
building=cabin 89126 Added
building=civic 53949
building=hotel 21776
building=houseboat 11520
building=kindergarten 13125
building=manufacture 94507
building=public 39377
building=service 95527
building=stable 10477 Added
building=static_caravan 26023
building=train_station 13938
construction=yes 48871 Ignored. Lifecycle
crop=corn 13629 Added
crop=grass 14186 Added
crop=rice 15795 Added
cuisine=coffee_shop 16997
entrance=staircase 66237
footway=crossing 135476
footway=sidewalk 217915
golf=bunker 64675
golf=fairway 24191
heritage=2 16686
heritage=4 14589
highway=proposed 51018 Ignored for now, see #11139
historic=building 11875
historic=yes 34631 Ignored. Lifecycle
landuse=conservation 24867
landuse=farm 572939
leisure=recreation_ground 27747
living_street=yes 193832 Ignored. Used only in Russia. unclear situation in relation to highway=living_street.
locality=townland 48104
maintenance=gritting 15556 Ignored. Empty wiki page and local usage, see taginfo map
man_made=mast 23646
man_made=petroleum_well 32326
man_made=silo 41194
military=bunker 23317
mooring=yes 18504 Added
oneway=-1 122298 We already have a validator warning.
oneway=1 10250 We already have a validator warning.
pipeline=marker 12322
place=allotments 12582
placement=right_of:1 17516 Added
placement=transition 12958 Added
railway=signal 40435
railway=stop 11325
residential=rural 125887 Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
residential=urban 15335 Ignored. Used only in Russia. Different concepts of refining residential landuse exist.
route=foot 26924
ruins=yes 33287
seamark=buoy 10212
service=crossover 16733 Added.
service=emergency_access 11623
smoking=outside 14449
surface=earth 24377 Ignored. Duplicate of ground and dirt (which are used much more) However not declared as deprecated in the wiki.
takeaway=yes 17507 Added
tidal=yes 16590 Added
traffic_sign=maxspeed 19063 Added
trolley_wire=yes 34577
wall=dry_stone 43074 Added
wall=no 10747377 Ignored. Used in French cadastre import
water=intermittent 269254 Deprecated. Validator Rule added.
waterway=rapids 44573 Difficult case. Was removed from mappaint in r8135 and r8767. The tag is clearly garbage, however there is no replacement, so a deprecation warning is not possible. Keep the situation as is for now.

Change History (30)

comment:1 Changed 5 years ago by Don-vip

In 9014/josm:

see #12102 - add crop=corn,grass,rice,wheat,hop to landuse=farmland preset

comment:2 Changed 5 years ago by Don-vip

Milestone: 15.11

comment:3 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:4 Changed 5 years ago by Don-vip

In 9015/josm:

see #12102 - add building=cabin,stable to Building preset

comment:5 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:6 Changed 5 years ago by Klumbumbus

There are some tags, which are neither deprecated, nor are they appropriate to use in a preset imho. Possible reasons are:

  • the definition is unclear
  • they are mainly used only in one country (and are maybe a result of an import), e.g. wall=no, living_street=yes
  • we previously decided to not add them (however we could rethink the dicision), e.g. highway=proposed
  • there is a similar tag, tagging scheme is undecided by community, e.g. amenity=swimming_pool, ice cream

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

Last edited 5 years ago by Klumbumbus (previous) (diff)

comment:7 in reply to:  6 Changed 5 years ago by Don-vip

Replying to Klumbumbus:

Would it be possible to create a list where we add these tags, so they do not appear in the "tag not in presets" warning (info level)?

Agreed. Let's update the table with these information for the unclear/ambiguous tags, and I'll code the list.

comment:8 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:9 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:10 Changed 5 years ago by Don-vip

In 9023/josm:

see #12102 - cleanup TagChecker

  • code refactor/cleanup/simplification
  • clean list of ignored tags by removing tags that have been added to internal presets during past years
  • add unit test to detect these tags if we add new tags to internal presets that are currently being ignored

comment:11 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:12 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:13 Changed 5 years ago by Don-vip

In 9024/josm:

see #12102 - ignore Lifecycle tags

comment:14 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:15 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:16 Changed 5 years ago by Klumbumbus

In 9026/josm:

see #12102 - add placement to major road preset

comment:17 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:18 Changed 5 years ago by Klumbumbus

In 9027/josm:

see #12102 - add takeaway to meal presets

comment:19 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:20 Changed 5 years ago by Klumbumbus

In 9028/josm:

see #12102 - add tidal to water presets

comment:21 Changed 5 years ago by Klumbumbus

In 9029/josm:

see #12102 - add floating and mooring to pier preset

comment:22 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:23 Changed 5 years ago by Klumbumbus

In 9030/josm:

see #12102 - add some tags to ignore list

comment:24 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:25 Changed 5 years ago by Klumbumbus

In 9031/josm:

see #12102 - add service=crossover to railway presets and deprecate water=intermittent

comment:26 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:27 Changed 5 years ago by Don-vip

In 9033/josm:

see #12102 - add wall=dry_stone,noise_barrier to barrier=wall preset

comment:28 Changed 5 years ago by Don-vip

Description: modified (diff)

comment:29 Changed 5 years ago by Don-vip

In 9034/josm:

see #12102 - add traffic_sign=maxspeed preset

comment:30 Changed 5 years ago by Don-vip

Description: modified (diff)
Note: See TracTickets for help on using tickets.