Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#12041 closed defect (fixed)

Wrong message in relation member deletion confirmation

Reported by: Don-vip Owned by: team
Priority: normal Milestone: 15.11
Component: Core Version:
Keywords: template_report i18n Cc:

Description

  1. Select several members of a given relation
  2. Delete them
  3. See erroneous message:


Revision: 8970
Is-Local-Build: true
Build-Date: 2015-10-31 18:48:30

Identification: JOSM/1.5 (8970 SVN en) Windows 7 64-Bit
Memory Usage: 1460 MB / 2708 MB (434 MB allocated, but free)
Java version: 1.8.0_66, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
VM arguments: [-Dfile.encoding=UTF-8]
Dataset consistency test: No problems found

Plugins:
- apache-commons (31718)
- geotools (31603)
- imagery-xml-bounds (31694)
- jts (31603)
- opendata (31695)
- utilsplugin2 (31694)

Attachments (1)

bug.png (47.0 KB) - added by Don-vip 4 years ago.

Download all attachments as: .zip

Change History (10)

Changed 4 years ago by Don-vip

Attachment: bug.png added

comment:1 Changed 4 years ago by simon04

Resolution: fixed
Status: newclosed

In 8975/josm:

fix #12041 - Wrong message in relation member deletion confirmation

comment:2 Changed 4 years ago by aceman

Are you sure this will work? Is there always the same number of objects then there is the number of relations? If not, you should probably use the "title1 + ' ' + title2" schema. That also isn't perfect, but at least better.

comment:3 Changed 4 years ago by holgermappt

Resolution: fixed
Status: closedreopened

The current Please confirm to remove {0} objects from {1} relations, lines 118-119 in core/src/org/openstreetmap/josm/gui/dialogs/DeleteFromRelationConfirmationDialog.java, doesn't work. Both objects and relations would need to translated for plural. That is not possible for languages that have multiple plural forms. That would be 9 combinations for a language with three plurals, but only three combinations can be entered. The only way to handle such a case is to split it into two sentences that are translated independently.

E.g. like this:

"<html>" +
trn("Please confirm to remove <strong>{0} object</strong>.",
    "Please confirm to remove <strong>{0} objects</strong>.",
    numObjectsToDelete, numObjectsToDelete)
+ " " +
trn("{0} relation is affected.",
    "{0} relations are affected.",
    numParentRelations, numParentRelations)
+ "</html>";

comment:4 Changed 4 years ago by aceman

Yes, that is what I wanted to say :)

comment:5 in reply to:  1 ; Changed 4 years ago by Don-vip

Replying to simon04:

In 8975/josm:

fix #12041 - Wrong message in relation member deletion confirmation

How exactly is QuirkyPluralString being used? Is it only a hint for developers, or is it now part of the i18n job?

comment:6 Changed 4 years ago by Don-vip

Keywords: i18n added

comment:7 in reply to:  5 Changed 4 years ago by simon04

Replying to Don-vip:

How exactly is QuirkyPluralString being used? Is it only a hint for developers, or is it now part of the i18n job?

This is only a marker to easier identify those kind strings (in case one came up with a universal solution). No behaviour is associated with this annotation.

comment:8 Changed 4 years ago by simon04

Resolution: fixed
Status: reopenedclosed

In 8989/josm:

fix #12041 - Wrong message in relation member deletion confirmation (by holgermappt)

comment:9 Changed 4 years ago by aceman

Thanks. Also for keeping the quirkyPluralString in place as such hardcoded concatenation is not 100% I18n-correct. But it's better now until a universal solution is found (as you write in comment 7).

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.