Modify

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#12011 closed defect (fixed)

undo "add node into way" causes exception

Reported by: malenki Owned by: team
Priority: normal Milestone: 15.10
Component: Core Version:
Keywords: template_report regression Cc:

Description (last modified by malenki)

What steps will reproduce the problem?

  1. switch to drawing mode (shortcut A)
  2. download some data
  3. double click on any way to add a node to it
  4. press "ctrl-z" to undo the previous action
  5. enjoy the exception

Please provide any additional information below. Attach a screenshot if possible.

r8904 ff have the issue, r8892 and previous don't have it

Tested with

  • blank ~/.josm
  • java version:

1.7.0_79
OpenJDK Runtime Environment (IcedTea 2.5.6) (7u79-2.5.6-1~deb8u1)
OpenJDK 64-Bit Server VM (build 24.79-b02, mixed mode)

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-10-19 01:33:25
Last Changed Author: Don-vip
Revision: 8904
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-10-19 00:46:00 +0200 (Mon, 19 Oct 2015)
Last Changed Rev: 8904

Identification: JOSM/1.5 (8904 de) Linux LMDE 2 Betsy
Memory Usage: 707 MB / 2222 MB (282 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u79-2.5.6-1~deb8u1
VM arguments: [-Dsun.java2d.opengl=false]
Dataset consistency test: No problems found

Plugins:
- FastDraw (31603)
- FixAddresses (31603)
- HouseNumberTaggingTool (31603)
- ImportImagePlugin (31603)
- InfoMode (31603)
- Mapillary (31688)
- OpeningHoursEditor (31603)
- PicLayer (31603)
- RoadSigns (31603)
- ShapeTools (1000)
- apache-commons (31674)
- apache-http (31684)
- buildings_tools (31640)
- conflation
- contourmerge (1013)
- download_along (31603)
- editgpx (31603)
- ext_tools (31603)
- fieldpapers
- geotools (31603)
- imagery_offset_db (31646)
- jts (31603)
- log4j (31603)
- mapdust (31603)
- measurement (31648)
- photo_geotagging (31677)
- photoadjust (31603)
- reltoolbox (31662)
- reverter (31625)
- tag2link (31603)
- tageditor (31615)
- terracer
- todo (29154)
- turnrestrictions (31638)
- undelete (31603)
- utilsplugin2
- waydownloader (31603)
- wikipedia (31603)

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'maxspeed_icon.svg'
- W: Mappaint style "standard" (Höchstgeschwindigkeit) icon "maxspeed_icon.svg" not found.
- E: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException. Ursache: java.lang.reflect.InvocationTargetException. Ursache: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=-398 version=0 MV lat=50.917470149406995,lon=13.350438899816366}
- E: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException. Ursache: java.lang.reflect.InvocationTargetException. Ursache: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=-406 version=0 MV lat=50.917163555735854,lon=13.350362078212308}
- E: java.lang.RuntimeException: java.lang.reflect.InvocationTargetException. Ursache: java.lang.reflect.InvocationTargetException. Ursache: org.openstreetmap.josm.data.osm.DataIntegrityProblemException: Primitive must be part of the dataset: {Node id=-408 version=0 MV lat=50.91717703910737,lon=13.35033962930902}

java.lang.RuntimeException: java.lang.reflect.InvocationTargetException
	at org.openstreetmap.josm.gui.mappaint.mapcss.Condition$PseudoClassCondition.applies(Condition.java:654)
	at org.openstreetmap.josm.gui.mappaint.mapcss.Selector$AbstractSelector.matches(Selector.java:465)
	at org.openstreetmap.josm.gui.mappaint.mapcss.MapCSSStyleSource.apply(MapCSSStyleSource.java:646)
	at org.openstreetmap.josm.gui.mappaint.ElemStyles.generateStyles(ElemStyles.java:318)
	at org.openstreetmap.josm.tools.ImageProvider.getPadded(ImageProvider.java:1287)
	at org.openstreetmap.josm.gui.OsmPrimitivRenderer.renderer(OsmPrimitivRenderer.java:76)
	at org.openstreetmap.josm.gui.OsmPrimitivRenderer.getListCellRendererComponent(OsmPrimitivRenderer.java:49)
	at org.openstreetmap.josm.gui.OsmPrimitivRenderer.getListCellRendererComponent(OsmPrimitivRenderer.java:29)
	at javax.swing.plaf.basic.BasicListUI.paintCell(BasicListUI.java:207)
	at javax.swing.plaf.basic.BasicListUI.paintImpl(BasicListUI.java:316)
	at javax.swing.plaf.basic.BasicListUI.paint(BasicListUI.java:239)
	at javax.swing.plaf.ComponentUI.update(ComponentUI.java:161)
	at javax.swing.JComponent.paintComponent(JComponent.java:770)
	at javax.swing.JComponent.paint(JComponent.java:1046)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JViewport.paint(JViewport.java:731)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at org.openstreetmap.josm.gui.widgets.MultiSplitPane.paintChildren(MultiSplitPane.java:205)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JSplitPane.paintChildren(JSplitPane.java:1047)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintChildren(JComponent.java:879)
	at javax.swing.JComponent.paint(JComponent.java:1055)
	at javax.swing.JComponent.paintToOffscreen(JComponent.java:5223)
	at javax.swing.BufferStrategyPaintManager.paint(BufferStrategyPaintManager.java:295)
	at javax.swing.RepaintManager.paint(RepaintManager.java:1249)
	at javax.swing.JComponent._paintImmediately(JComponent.java:5171)
	at javax.swing.JComponent.paintImmediately(JComponent.java:4982)
	at javax.swing.RepaintManager$3.run(RepaintManager.java:808)
	at javax.swing.RepaintManager$3.run(RepaintManager.java:796)
	at java.security.AccessController.doPrivileged(Native Method)
	at java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:76)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:796)
	at javax.swing.RepaintManager.paintDirtyRegions(RepaintManager.java:769)
	at javax.swing.RepaintManager.prePaintDirtyRegions(RepaintManager.java:718)
	at javax.swing.RepaintManager.access$1100(RepaintManager.java:62)
	at javax.swing.RepaintManager$ProcessingRunnable.run(RepaintManager.java:1677)
...<snip>...

Attachments (0)

Change History (7)

comment:1 by malenki, 8 years ago

Description: modified (diff)

comment:2 by Don-vip, 8 years ago

Milestone: 15.10

comment:3 by Don-vip, 8 years ago

Summary: undo "add node to way" causes exceptionundo "add node into way" causes exception

comment:4 by Don-vip, 8 years ago

Regression of r8903.

comment:5 by Don-vip, 8 years ago

In 8949/josm:

see #11968, see #12011 - add a new non-regression unit test reproducing #12011

comment:6 by Don-vip, 8 years ago

Resolution: fixed
Status: newclosed

In 8950/josm:

fix #12011 - add robustness

comment:7 by Klumbumbus, 8 years ago

Last errors/warnings:
- E: Fehler beim Laden des Bildes 'maxspeed_icon.svg'
- W: Mappaint style "standard" (Höchstgeschwindigkeit) icon "maxspeed_icon.svg" not found.

can you please check the URL and version of your maxspeed mappaint style?

mappaint stile Dialog -> Rechtsklick auf Höchsgeschwindigkeit -> Info -> URL nach "Adresse:"

und dann im "Quelle" tab version: "...";

Last edited 8 years ago by Klumbumbus (previous) (diff)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.