Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11968 closed enhancement (fixed)

[PATCH] Show node icons from style in selection list and relation editor.

Reported by: augustus.kling@… Owned by: team
Priority: normal Milestone: 15.10
Component: Core Version:
Keywords: selection, relation editor, icons Cc: Klumbumbus

Description

This patch changes the rendering of nodes such that their specific icons are shown in the selection list and the relation editor. This should make it easier to spot nodes in the list/tables.

The rendering of lines, areas, relations and nodes without a specific icon is unaffected. Since the patch assumes a row height of 16px in the selection list, somebody should test with another system than mine (Kubuntu) to make sure this assumption is valid.

Attachments (2)

node-icons.patch (8.7 KB) - added by augustus.kling@… 4 years ago.
node-icons.png (171.6 KB) - added by augustus.kling@… 4 years ago.
Effect of the patch.

Download all attachments as: .zip

Change History (13)

Changed 4 years ago by augustus.kling@…

Attachment: node-icons.patch added

Changed 4 years ago by augustus.kling@…

Attachment: node-icons.png added

Effect of the patch.

comment:1 Changed 4 years ago by augustus.kling@…

Please see the screenshot to see the effect of the patch (the added icons for nodes).
Effect of the patch.

comment:2 Changed 4 years ago by Klumbumbus

Cc: Klumbumbus added

comment:3 Changed 4 years ago by Don-vip

Milestone: 15.10

comment:4 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8903/josm:

fix #11968 - Show node icons from style in selection list and relation editor (patch by Augustus Kling)

comment:5 Changed 4 years ago by Don-vip

Nice patch, thanks! :)

comment:6 Changed 4 years ago by augustus.kling@…

You're welcome, glad you like it.

comment:7 Changed 4 years ago by Klumbumbus

This also affects other dialogs like the upload dialog or the turn restrictions plugin (diaplaying traffic light icon for via node). Great!

comment:8 Changed 4 years ago by Don-vip

It causes a problem with undo, see #12011

comment:9 Changed 4 years ago by Don-vip

In 8949/josm:

see #11968, see #12011 - add a new non-regression unit test reproducing #12011

comment:10 Changed 4 years ago by simon04

In 9265/josm:

see #7089 see #11968 - Obtain icons from presets for nodes/relations in selection/relation list/editor

comment:11 Changed 4 years ago by Don-vip

In 9867/josm:

see #11968, fix #12550 - in relation editor, node features are shown without name (only icon, regression from r8903)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.