Modify

Opened 4 years ago

Closed 4 years ago

#11989 closed defect (fixed)

middle click function broken

Reported by: rickmastfan67 Owned by: team
Priority: major Milestone: 15.10
Component: Core Version: latest
Keywords: regression Cc: michael2402

Description

It seems that a very recent change has broken the 'middle click' function in JOSM when you have a data layer open. The last 'latest' that worked was r8892. This function is very important when you're trying to select a way that is merged with another, or a relation that's part of the way. If I had to take a guess on which change broke it, I think it might have been [8900].

Steps to reproduce:

  1. Load some data from OSM.
  2. Attempt to use your middle click on your mouse to have the popup data window show up to select what you want to access.

What happens:
Nothing.

What should happen:
The popup window should show up displaying the way info/relations attached to it.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-10-19 01:33:25
Last Changed Author: Don-vip
Revision: 8904
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-10-19 00:46:00 +0200 (Mon, 19 Oct 2015)
Last Changed Rev: 8904

Identification: JOSM/1.5 (8904 en) Windows 7 64-Bit
Memory Usage: 633 MB / 1820 MB (523 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- OpeningHoursEditor (31603)
- buildings_tools (31640)
- measurement (31603)
- osmarender (31603)
- reverter (31625)
- turnrestrictions (31638)
- undelete (31603)
- utilsplugin2 (31603)

Attachments (1)

0001-Fix-11989-MouseState-not-containing-mousePos.patch (1.9 KB) - added by michael2402 4 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 4 years ago by Don-vip

Cc: michael2402 added
Milestone: 15.10

Confirmed regression of r8900 (#11986). Michael can you please have a look?

Last edited 4 years ago by Don-vip (previous) (diff)

comment:2 Changed 4 years ago by michael2402

Sorry, my bad. MouseState did not always receive the current mousePos.

I fixed this and marked those fields as final to make it impossible to forget them again.

comment:3 Changed 4 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 8907/josm:

fix #11989 - middle click function broken (patch by michael2402)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.