Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11862 closed defect (fixed)

Validator complains about noname=yes, but at the same time the key is used in MapCSS tests.

Reported by: mdk Owned by: team
Priority: normal Milestone: 15.09
Component: Core validator Version: latest
Keywords: Cc:

Description

noname=yes is used 28'000 times and also at least by one MapCSS test. But the validator is also complaining, that the key is not known.

Attachments (0)

Change History (5)

comment:1 Changed 4 years ago by Klumbumbus

This is info level. The validator just gives you an info. Also it does not say that it is not known, but Key ''{0}'' not in presets. So it is just a info that the key is not part of a installed preset. This does not mean that the key is always wrong. There are a lot of keys, which are absolutely ok, but not part of a preset.

I don't think that adding a noname=yes checkbox to all presets with name would be good.

comment:2 in reply to:  1 Changed 4 years ago by mdk

Replying to Klumbumbus:

I don't think that adding a noname=yes checkbox to all presets with name would be good.

I agree that this doesn't make sense. But I would set noname=yes only when a name is normally required.

To be pragmatic: Only when a Validator rule includes noname=yes, the preset should offer the appropriate checkbox. The only candidates today are:

  • amenity=restaurant|cafe|fast_food
  • highway=unclassified

and thats it!

comment:3 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8755/josm:

fix #11862 - add noname=yes checkbox to highway=unclassified|residential presets

comment:4 Changed 4 years ago by Klumbumbus

Milestone: 15.09

We don't the checkbox for amenity=restaurant|cafe|fast_food, there are only 2 uses total. http://overpass-turbo.eu/s/bqu

comment:5 in reply to:  4 Changed 4 years ago by mdk

Replying to Klumbumbus:

We don't the checkbox for amenity=restaurant|cafe|fast_food, there are only 2 uses total. http://overpass-turbo.eu/s/bqu

When I start writing my first response, I hat a sentense about the probability of (fastfood) restaurants and cafes without name, but that they are so uncommen, I hadn't expected :-)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.