Modify

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11769 closed enhancement (fixed)

[Patch] Documentation for KeyCondition

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 15.08
Component: Core mappaint Version:
Keywords: javadoc Cc:

Description

I documented the MapCSS conditions a bit and changed the if/else to a switch/case for.KeyMatchType.

Attachments (2)

documentation-key-condition.patch (8.0 KB ) - added by michael2402 9 years ago.
0001-Changed-test-case-to-test-for-EQ-match-type-instead-.patch (1.5 KB ) - added by michael2402 9 years ago.

Download all attachments as: .zip

Change History (9)

by michael2402, 9 years ago

comment:1 by michael2402, 9 years ago

Component: CoreCore mappaint

comment:2 by Don-vip, 9 years ago

Keywords: javadoc added
Milestone: 15.08

comment:3 by Don-vip, 9 years ago

Resolution: fixed
Status: newclosed

In 8654/josm:

fix #11769 - Documentation for KeyCondition (patch by michael2402)

comment:4 by Don-vip, 9 years ago

Resolution: fixed
Status: closedreopened

it seems to cause test failures, can you please have a look at jenkins/job/JOSM/49/testReport/?

comment:5 by michael2402, 9 years ago

matchType = null was handled the same way as matchType = EQ. The test explicitly tested for null, this is why it failed.

comment:6 by Don-vip, 9 years ago

Resolution: fixed
Status: reopenedclosed

In 8657/josm:

fix #11769 - fix unit test (patch by michael2402)

comment:7 by Don-vip, 9 years ago

thanks! :)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment


E-mail address and name can be saved in the Preferences .
 
Note: See TracTickets for help on using tickets.