Modify ↓

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#11647 closed defect (fixed)

Regression: relation list empty

Reported by: malenki Owned by: team
Priority: critical Milestone: 15.08
Component: Core Version:
Keywords: regression relation Cc: michael2402, bastiK

Description

Between r8525 and r8562 and something got changed so that now when loading an area with relations the relation list in JOSM remains empty.

Attachments (4)

2015-07-04_125309_scr.png​ (153.4 KB ) - added by malenki 9 years ago.
JOSM with relations loaded and one selected but not showing them in the relation list
0001-Made-setActiveLayer-fire-the-edit-layer-change-liste.patch​ (9.4 KB ) - added by michael2402 9 years ago.
0002-MapView-Use-enum-set-instead-of-integer-flags.2.patch​ (7.6 KB ) - added by michael2402 9 years ago.
0002-MapView-Use-enum-set-instead-of-integer-flags.patch​ (7.6 KB ) - added by michael2402 9 years ago.

Download all attachments as: .zip

Change History (13)

by malenki, 9 years ago

Attachment: 2015-07-04_125309_scr.png​ added

JOSM with relations loaded and one selected but not showing them in the relation list

comment:1 by Don-vip, 9 years ago

Keywords: regression relation added
Milestone: → 15.07

comment:2 by Don-vip, 9 years ago

Cc: michael2402 bastiK added

regression from r8548:8556

comment:3 by Don-vip, 9 years ago

Priority: major → critical

r8551 maybe? I don't see what's wrong right now, can you please have a look?

comment:4 by michael2402, 9 years ago

setActiveLayer(...) was not firing the edit layer change listeners even if the edit layer was also changed. This is why the relation editor never got updated. I attached a patch that fixes this.

Last edited 9 years ago by michael2402 (previous) (diff)

comment:5 by bastiK, 9 years ago

The patch doesn't apply to HEAD (r8567).

(Integer flags are fine, but EnumSet would be more self-documenting.)

by michael2402, 9 years ago

Attachment: 0001-Made-setActiveLayer-fire-the-edit-layer-change-liste.patch​ added

comment:6 by michael2402, 9 years ago

Thanks for pointing that out. I tested it against the current git head, it should merge now.

I also added a patch to change the flags to enum flags (apply after the first one)

by michael2402, 9 years ago

Attachment: 0002-MapView-Use-enum-set-instead-of-integer-flags.2.patch​ added

by michael2402, 9 years ago

Attachment: 0002-MapView-Use-enum-set-instead-of-integer-flags.patch​ added

comment:7 by bastiK, 9 years ago

Resolution: → fixed
Status: new → closed

In 8573/josm:

fixed #11647 - Regression: relation list empty (patch by michael2402)

comment:8 by bastiK, 9 years ago

Thanks for the quick fix!

comment:9 by Don-vip, 9 years ago

Milestone: 15.07 → 15.08

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.