Modify ↓
#11628 closed enhancement (fixed)
[Patch] Added documentation to EastNorth, changed x - y = y.sub(x) to x.subtract(y) and minor code style improvements.
| Reported by: | michael2402 | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.08 |
| Component: | Core | Version: | |
| Keywords: | gsoc | Cc: |
Description
An access to x is not much faster than a east()-method call, since the JIT can inline that access.
The current meaning of sub is to subtract from. I changed it to a normal subtract, which has the same meaning as in Point2D.
Attachments (1)
Change History (6)
by , 10 years ago
| Attachment: | 0002-Added-documentation-to-EastNorth-changed-x-y-y.sub-x.patch added |
|---|
comment:1 by , 10 years ago
| Summary: | Added documentation to EastNorth, changed x - y = y.sub(x) to x.subtract(y) and minor code style improvements. → [Patch] Added documentation to EastNorth, changed x - y = y.sub(x) to x.subtract(y) and minor code style improvements. |
|---|
comment:2 by , 10 years ago
| Keywords: | gsoc added |
|---|---|
| Milestone: | → 15.07 |
comment:3 by , 10 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:4 by , 10 years ago
As stated in #11625, I find it simpler and more efficient to use the "inlined" formulas. (Just a matter of taste.)
Math.hypot is extremely slow and shouldn't be used in any code that could be relevant for performance.
Note:
See TracTickets
for help on using tickets.
In 8549/josm: