Modify

Opened 3 years ago

Closed 2 months ago

Last modified 7 weeks ago

#11556 closed enhancement (fixed)

switch imagery layer pressing tilde (~) or square (²) key

Reported by: kimmybjonsson Owned by: Don-vip
Priority: normal Milestone: 18.06
Component: Core imagery Version:
Keywords: Cc:

Description

Using the latest version where better zoom in Mapbox Satellite imagery was introduced, I am now able to draw buildings with better geographic accuracy in hilly areas. However, the satellite imagery is of significantly lower resolution and so it is often necessary for me to switch between aerial and satellite in order to locate buildings.
Switching between them two currently takes up a lot of time. Having a hotkey for the operation would save me a lot of time in my work.
Tilde key for switch?

Attachments (4)

aerialVSsatellite.gif (1.1 MB) - added by kimmybjonsson 3 years ago.
aerial for details, satellite for accuracy
11556.patch (4.4 KB) - added by Don-vip 3 months ago.
qwertz-polish.png (284.5 KB) - added by Don-vip 7 weeks ago.
11556.png (5.7 KB) - added by Klumbumbus 7 weeks ago.

Download all attachments as: .zip

Change History (27)

Changed 3 years ago by kimmybjonsson

Attachment: aerialVSsatellite.gif added

aerial for details, satellite for accuracy

comment:1 Changed 3 years ago by wiktorn

How do this tile key should work? Take first-from-top TMS/WMS layer and switch? Take second from below and switch visibility?

Or maybe it would be good, if you could just select the layer for "quick view", and set this by right-clicking on layer in layer list, and choosing such option from menu?

I often work with more than 2 TMS/WMS layer at the same time (all visible), so it would be hard to guess, which layer I'm thinking about.

comment:2 Changed 3 years ago by kimmybjonsson

Thank you for your reply. It would probably work by deselecting the currect layer I guess. That way the imagery layer below would be visible. When user wish to switch back, it just hit the hot key again and once more the first imagery layer would become visible again .

For me, a hotkey close to S and B would be preferable, as I tend to touch those two keys often.

comment:3 Changed 3 years ago by wiktorn

How do you define current layer? The one that's active? That's usually layer containing OSM data.

There is no obvious way to define, which layer is current, as some layers are transparent, so you can actually see joint effect of few layers at your screen. That's why I propose manually selecting which layer should have this behaviour.

Any ideas are most welcome.

comment:4 Changed 3 years ago by kimmybjonsson

I concur. And better yet, having the key user definable in opposite of hard coding the hotkey I think would improve efficiency.

comment:5 Changed 3 years ago by akks

Did you try Shift-S shortcut? It asks the layer number but seem do what requested.
(use like Shift-S, 2 to show/hide 2nd layer)

comment:6 in reply to:  5 Changed 3 years ago by kimmybjonsson

Replying to akks:

Did you try Shift-S shortcut? It asks the layer number but seem do what requested.
(use like Shift-S, 2 to show/hide 2nd layer)

Indeed it does! Thank you for the tip, I was not aware of that hotkey combo and saw nothing of it in the help. However, doing this operation is slower than just pressing a hotkey, and possibly just even slower than clicking the toggle visibility button of the layer itself. I still feel that a single press of a hotkey is the way to go.

comment:7 Changed 3 months ago by Don-vip

We have the information in Maps if the layer is an overlay.

So we could add a shortcut with tilde key which reorders all non-overlay imagery layers in a cyclic manner.

comment:8 Changed 3 months ago by Don-vip

Milestone: 18.06

comment:9 Changed 3 months ago by Don-vip

Owner: changed from team to Don-vip
Status: newassigned
Summary: switch image layer pressing tilde buttonswitch image layer pressing tilde (~) or square (²) button

For AZERTY layout (French) the ² key must be used.

comment:10 Changed 3 months ago by Don-vip

Summary: switch image layer pressing tilde (~) or square (²) buttonswitch imagery layer pressing tilde (~) or square (²) key

Changed 3 months ago by Don-vip

Attachment: 11556.patch added

comment:11 Changed 2 months ago by Don-vip

Resolution: fixed
Status: assignedclosed

In 13891/josm:

fix #11556 - switch imagery layer pressing tilde (~) or square (²) key

comment:12 Changed 2 months ago by Klumbumbus

Could someone please document this feature for end users in our wiki?

comment:13 Changed 7 weeks ago by Don-vip

How do you make your .gif captures?

comment:14 Changed 7 weeks ago by Klumbumbus

comment:16 Changed 7 weeks ago by Klumbumbus

My keyboard layout is QWERTZ (german) and in the shortcut preferences ² is assigned but nothing happens when I press ² or ~ with several loaded imagery entries.

URL:https://josm.openstreetmap.de/svn/trunk
Repository:UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last:Changed Date: 2018-07-01 23:07:04 +0200 (Sun, 01 Jul 2018)
Build-Date:2018-07-01 21:10:23
Revision:13996
Relative:URL: ^/trunk

Identification: JOSM/1.5 (13996 de) Windows 10 64-Bit
OS Build number: Windows 10 Pro 1803 (17134)
Memory Usage: 1867 MB / 3641 MB (1196 MB allocated, but free)
Java version: 1.8.0_171-b11, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Screen: \Display0 1680x1050
Maximum Screen Size: 1680x1050
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:<java.home>\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files (x86)\josm-latest-mehr-RAM.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=1024m,4096m, -Djnlpx.splashport=62934, -Djnlpx.jvm=<java.home>\bin\javaw.exe]
Dataset consistency test: No problems found

comment:17 Changed 7 weeks ago by Don-vip

Crap. The goal is to use the key next to "1". What is it in QWERTZ? For polish keyboard I see this strange character:


Changed 7 weeks ago by Don-vip

Attachment: qwertz-polish.png added

comment:19 Changed 7 weeks ago by Don-vip

Wow there is a lot of variants:

Germany:
https://upload.wikimedia.org/wikipedia/commons/3/36/KB_Germany.svg
Swiss:
https://upload.wikimedia.org/wikipedia/commons/4/4f/KB_Swiss.svg
Slovene:
https://upload.wikimedia.org/wikipedia/commons/2/2e/KB_Slovene.svg
Hungary:
https://upload.wikimedia.org/wikipedia/commons/a/a8/KB_Hungary.svg

I don't know if we can map the physical key instead of the character.

Changed 7 weeks ago by Klumbumbus

Attachment: 11556.png added

comment:20 Changed 7 weeks ago by Klumbumbus

When I click on the menu entry with the mouse it works, but no shortcut works. Also here it says ~ while in the preferences it says ²


comment:21 Changed 7 weeks ago by Don-vip

Both keys are mapped, you should see two entries with same text in shortcut preferences.

comment:22 Changed 7 weeks ago by Don-vip

Wow it's really hard to get physical key codes in Java (scancodes). It either requires JNI/JNA (no-go for JOSM) or reflection into OpenJDK classes, but it seems to work only for Windows (also no-go).

I can't register all possible keys at the same time but maybe I can, based on current locale, register the three/four plausible characters. Even if not perfect, this should work for most of our users.

comment:23 Changed 7 weeks ago by Don-vip

Follow-up: #16453

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain Don-vip.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.