tag2link plugin support of image=*

[Klumbumbus]

It would be nice if urls which are in the image tag are supported.

Example: ​https://www.openstreetmap.org/node/2904501132

[Klumbumbus]

fixed in [o31825]

...atleast I hope it is fixed, I will test my regexp tomorrow :)

[Klumbumbus]

I think I need to commit also the compiled jar file. I need some time to figure this out...

[simon04]

Re-compiled in [o31868].

Here's what I did:

$ cd plugins/tag2link
$ ant clean dist
$ svn ci

See DevelopersGuide/DevelopingPlugins for detailed instructions.

[Klumbumbus]

It is still version 31867 in Plugins. Did you maybe accidently compile the old version?

---

I was fighting hard with jdk and eclipse yesterday. When I finally managed to compile this plugin it failed with 83 errors and 1 warning...

So I decided to try this again later ;)

[simon04]

It is (almost) correct: It states the version when the plugin was last changed. This is somehow covered in wiki:DevelopersGuide/DevelopingPlugins#UpdatingaplugininSVN

In fact it should report 31825 and not 31867. This is due to a bug in [o30161], and fixed now in [o31886].

Building a plugin might be easier using Ant directly since setting up all the paths and dependencies for JOSM in IDEs such as Eclipse is a challenging part …

[simon04]

[o31902:31903].

The tag is matched against v, thus the pattern must cover the whole string, see ​https://docs.oracle.com/javase/7/docs/api/java/lang/String.html#matches%28java.lang.String%29.

[Klumbumbus]

Thanks for fixing! Could you please also compile and upload #11571? Would be great.

[Klumbumbus]

The approach with File: does not work correct, because whitespaces are replaced by pluses in the URL. See e.g. ​http://www.openstreetmap.org/way/367011285

[simon04]

This is hard work ;) – I extended the hack:

plugins/tag2link/src/org/openstreetmap/josm/plugins/tag2link/Tag2LinkRuleChecker.java

@@ -109 +109 @@
             if (val != null) {
                 try {
                     // Special hack for Wikipedia that prevents spaces being replaced by "+" characters, but by "_"
-                    if (s.contains("wikipedia.")) {
+                    if (s.contains("wikipedia.") || s.contains("commons.wikimedia.org")) {
                         val = val.replaceAll(" ", "_");
                     }
                     // Encode param to be included in the URL, except if it is the URL itself !

Fixed in [o31910:31911].

[Klumbumbus]

Thanks :)