Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11327 closed enhancement (fixed)

Add possibility to clear from cache only specified TileSource

Reported by: wiktorn Owned by: wiktorn
Priority: normal Milestone: 15.08
Component: Core imagery Version:
Keywords: Cc:

Description

As mentioned in #11312, the only feature that imagerycache has, that JOSM doesn't, is ability to remove specified TileSource from the cache. It should be quite easy to implement using prefixes within JCS.

Attachments (0)

Change History (15)

comment:1 Changed 4 years ago by bastiK

Resolution: fixed
Status: newclosed

In [8186].

comment:2 in reply to:  1 Changed 4 years ago by wiktorn

Resolution: fixed
Status: closedreopened

You probably meant #11319 :)

comment:3 Changed 4 years ago by bastiK

Yep...

comment:4 Changed 4 years ago by Don-vip

Milestone: 15.0515.06

comment:5 Changed 4 years ago by Don-vip

Milestone: 15.0615.07

skip milestone 15.06

comment:6 in reply to:  1 Changed 4 years ago by wiktorn

Resolution: fixed
Status: reopenedclosed

In [8598] - possiblity to clear cache only for one TileSource.

comment:7 Changed 4 years ago by rickmastfan67

Resolution: fixed
Status: closedreopened

Sorry, but it's not working.

I go into the area where I need to clear the cache, and clear it. However, the 'TMS.data' file doesn't get smaller at all. Only the 'TMS.key' file seems to get anything changed in it per the time stamps on the files.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2015-07-13 01:32:13
Last Changed Author: wiktorn
Revision: 8599
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2015-07-13 00:53:49 +0200 (Mon, 13 Jul 2015)
Last Changed Rev: 8599

Identification: JOSM/1.5 (8599 en) Windows 7 64-Bit
Memory Usage: 361 MB / 1820 MB (214 MB allocated, but free)
Java version: 1.7.0_79, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM

Plugins:
- OpeningHoursEditor (31241)
- buildings_tools (31361)
- measurement (31289)
- mirrored_download (31294)
- osmarender (31241)
- reverter (31241)
- turnrestrictions (31241)
- undelete (31241)
- utilsplugin2 (31241)

comment:8 Changed 4 years ago by wiktorn

File is defragmented on JOSM close, so file size should change only after JOSM is closed

comment:9 Changed 4 years ago by rickmastfan67

I closed JOSM several times. Not once did the file shrink in size.

comment:10 Changed 4 years ago by wiktorn

Status: reopenednew

Have you checked the counts of the objects in the new tab in Imagery Preferences? Maybe the number of the objects in specified source were negligible, or the reclaimed space was reused by some other data.

I'll try to reproduce with the generated jar later.

comment:11 Changed 4 years ago by wiktorn

Status: newassigned

comment:12 Changed 4 years ago by rickmastfan67

Ok, I panned around in the 'Download data' window to have several images downloaded from the 'Mapnik' layer. The 'TMS.data' file is now at 1,493 KB in size. I then go into the 'Cache contents' tab in Imagery and notice it says that the 'Objects count' is 65 for that image source.

Now, I hit the clear button. 'Object count' is now reduced to 0. I hit the 'OK' button at the bottom of the preferences thinking that my cache has been cleared. Now I close JOSM. I once again check the 'TMS.data' file size. It's still 1,493 KB. Thus, it means the images weren't cleared from the cache at all.

I then go back into JOSM and into the 'Cache contents' section to prove this is the case. The 'Objects count' is once again back to 65.

So, this proves (at least on Windows), that the cache clearing of each Imagery source isn't working yet. :(

comment:13 Changed 4 years ago by wiktorn

Resolution: fixed
Status: assignedclosed

In 8600/josm:

  • fix sonar issues
  • implement cache clear for "clear" button

Closes: #11327

comment:14 Changed 4 years ago by rickmastfan67

It's now clearing the selected imagery source on closure of JOSM. :) Thanks for fixing that quickly.

comment:15 Changed 4 years ago by Don-vip

Milestone: 15.0715.08

Milestone renamed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain wiktorn.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.