#11257 closed enhancement (fixed)
[Patch] Drop dependency on Apache Commons Codec
| Reported by: | floscher | Owned by: | team |
|---|---|---|---|
| Priority: | normal | Milestone: | 15.03 |
| Component: | Core | Version: | |
| Keywords: | Cc: |
Description
Patch-file: https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32.patch
The dependency on Apache Commons Codec is only needed for Base64 decoding, which can be done with a tool from JAXB, which is part of JavaSE since 1.6 (javax.xml.bind.DatatypeConverter).
This patch replaces both the Base64 decoder from Apache Commons Codec and the one from the Sun-packages with the previously mentioned one.
See also https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32
Attachments (1)
Change History (11)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
OK, see https://github.com/floscher/josm/commit/f44a63833a45ee8f67589334f56549a5d7b72fa4.patch for the raw cleaned up patch and https://github.com/floscher/josm/commit/f44a63833a45ee8f67589334f56549a5d7b72fa4 for the pretty formatted version.
comment:3 Changed 8 years ago by
I almost forgot to say:
This patch of course obviates the need for the svn-external
/src/org/apache/commons/codec http://svn.apache.org/repos/asf/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec
As I don't have any experience with svn-externals, I don't know how to include the removal of one in a patch, if this is even possible.
comment:5 Changed 8 years ago by
| Milestone: | → 15.03 |
|---|
Changed 8 years ago by
| Attachment: | 0001-Updated-README-to-reflect-changes-in-r8149.patch added |
|---|
comment:6 Changed 8 years ago by
This new patch removes Apache Commons Codec also from the list of third party libraries.
comment:8 Changed 8 years ago by
I'm 100% sure I already did that. Probably forgot to save the file :-)
Please cleanup the patch and remove all unnecessary changes like whitespace fixes.