Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#11257 closed enhancement (fixed)

[Patch] Drop dependency on Apache Commons Codec

Reported by: floscher Owned by: team
Priority: normal Milestone: 15.03
Component: Core Version:
Keywords: Cc:

Description

Patch-file: https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32.patch

The dependency on Apache Commons Codec is only needed for Base64 decoding, which can be done with a tool from JAXB, which is part of JavaSE since 1.6 (javax.xml.bind.DatatypeConverter).

This patch replaces both the Base64 decoder from Apache Commons Codec and the one from the Sun-packages with the previously mentioned one.

See also https://github.com/floscher/josm/commit/542367b2fa806ac0b96206650245722bfaa5cb32

Attachments (1)

0001-Updated-README-to-reflect-changes-in-r8149.patch (1.1 KB) - added by floscher 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 Changed 4 years ago by stoecker

Please cleanup the patch and remove all unnecessary changes like whitespace fixes.

comment:3 Changed 4 years ago by floscher

I almost forgot to say:

This patch of course obviates the need for the svn-external

/src/org/apache/commons/codec http://svn.apache.org/repos/asf/commons/proper/codec/trunk/src/main/java/org/apache/commons/codec

As I don't have any experience with svn-externals, I don't know how to include the removal of one in a patch, if this is even possible.

comment:4 Changed 4 years ago by stoecker

Resolution: fixed
Status: newclosed

In 8149/josm:

fix #11257 - Remove apache.commons.codecs - patch by Florian Schaefer

comment:5 Changed 4 years ago by stoecker

Milestone: 15.03

comment:6 Changed 4 years ago by floscher

This new patch removes Apache Commons Codec also from the list of third party libraries.

comment:7 Changed 4 years ago by stoecker

In 8150/josm:

see #11257 - fix README

comment:8 Changed 4 years ago by stoecker

I'm 100% sure I already did that. Probably forgot to save the file :-)

comment:9 Changed 4 years ago by Don-vip

plugin native-password-manager needs adaptation:

http://donvip.fr/jenkins/job/JOSM-Plugins/1062/console

comment:10 in reply to:  9 Changed 4 years ago by bastiK

Replying to Don-vip:

plugin native-password-manager needs adaptation:

http://donvip.fr/jenkins/job/JOSM-Plugins/1062/console

Fixed in [o31061].

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.