Modify ↓

Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#11250 closed defect (fixed)

[Patch] User#userMap is not synchronized

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 15.03
Component: Core Version:
Keywords: Cc:

Description

This should not trigger often, but if it does, it might screw things up a lot (since HashMap is not synchronized itself).

Attachments (1)

0001-Made-user-map-synchronized.patch​ (3.5 KB ) - added by michael2402 11 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 by bastiK, 11 years ago

Yes, this looks unsafe. Why not simply add a synchronized modifier for the methods?

comment:2 by michael2402, 11 years ago

Using a plain synchronized would also work in this case.

comment:3 by bastiK, 11 years ago

Could you update the patch using plain synchronized?

by michael2402, 11 years ago

Attachment: 0001-Made-user-map-synchronized.patch​ added

comment:4 by michael2402, 11 years ago

I updated the patch.

comment:5 by bastiK, 11 years ago

Resolution: → fixed
Status: new → closed

In 8155/josm:

applied #11250 - User#userMap is not synchronized (patch by michael2402)

comment:6 by bastiK, 11 years ago

Thanks!

comment:7 by Don-vip, 11 years ago

Milestone: → 15.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.