Modify ↓

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#11249 closed enhancement (fixed)

[Patch] Remove some unneccessary variable boxing.

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 15.03
Component: Core Version:
Keywords: Cc:

Description

Removes unneccessary boxing in:

  • DateUtils
  • AbstractParser

Attachments (1)

0001-Removed-unneccessary-boxing-of-ints-doubles.patch​ (4.7 KB ) - added by michael2402 10 years ago.

Download all attachments as: .zip

Change History (6)

by michael2402, 10 years ago

Attachment: 0001-Removed-unneccessary-boxing-of-ints-doubles.patch​ added

comment:1 by bastiK, 10 years ago

You cannot compare with Double.NaN like this, otherwise okay.

comment:2 by stoecker, 10 years ago

I don't like it. It introduces an strange programming style without any real advantage. If it would be in a size or time critical part of the software and optimizations would improve memory footprint or processing, but I doubt that's the case here.

comment:3 by stoecker, 10 years ago

P.S. I mean the Double part, the other two changes aren't problematic.

comment:4 by bastiK, 10 years ago

Resolution: → fixed
Status: new → closed

In 8148/josm:

applied #11249 - Remove some unneccessary variable boxing (patch by Michael Zangl)

comment:5 by Don-vip, 10 years ago

Milestone: → 15.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted. Next status will be 'reopened'.

Add Comment
E-mail address and name can be saved in the Preferences .
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.