Modify ↓

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#11249 closed enhancement (fixed)

[Patch] Remove some unneccessary variable boxing.

Reported by: michael2402 Owned by: team
Priority: normal Milestone: 15.03
Component: Core Version:
Keywords: Cc:

Description

Removes unneccessary boxing in:

  • DateUtils
  • AbstractParser

Attachments (1)

0001-Removed-unneccessary-boxing-of-ints-doubles.patch​ (4.7 KB) - added by michael2402 8 years ago.

Download all attachments as: .zip

Change History (6)

Changed 8 years ago by michael2402

Attachment: 0001-Removed-unneccessary-boxing-of-ints-doubles.patch​ added

comment:1 Changed 8 years ago by bastiK

You cannot compare with Double.NaN like this, otherwise okay.

comment:2 Changed 8 years ago by stoecker

I don't like it. It introduces an strange programming style without any real advantage. If it would be in a size or time critical part of the software and optimizations would improve memory footprint or processing, but I doubt that's the case here.

comment:3 Changed 8 years ago by stoecker

P.S. I mean the Double part, the other two changes aren't problematic.

comment:4 Changed 8 years ago by bastiK

Resolution: → fixed
Status: new → closed

In 8148/josm:

applied #11249 - Remove some unneccessary variable boxing (patch by Michael Zangl)

comment:5 Changed 8 years ago by Don-vip

Milestone: → 15.03

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment

E-mail address and name can be saved in the Preferences.

Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.