Modify

Opened 6 years ago

Closed 6 years ago

#11246 closed defect (fixed)

add warning for way direction change of `man_made_embankment` and `embankment=yes`

Reported by: Klumbumbus Owned by: team
Priority: normal Milestone: 15.05
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by skyper)

There is no such a warning like for natural=cliff when you change the way direction of a way tagged with man_made=embankment and embankment=yes, that it is direction depended.

Revision: 8145
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: Klumbumbus
Last Changed Date: 2015-03-16 23:07:23 +0100 (Mon, 16 Mar 2015)
Build-Date: 2015-03-18 02:31:09
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8145

Identification: JOSM/1.5 (8145 de) Windows 7 32-Bit
Memory Usage: 481 MB / 742 MB (52 MB allocated, but free)
Java version: 1.8.0_31, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre1.8.0_31\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=61866, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Program arguments: [--debug]
Dataset consistency test: No problems found

Plugins:
- DirectDownload (30892)
- DirectUpload (30892)
- HouseNumberTaggingTool (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- RoadSigns (30977)
- Tracer2 (30984)
- buildings_tools (30955)
- download_along (30892)
- editgpx (30892)
- imagery_offset_db (31056)
- measurement (30892)
- mirrored_download (30962)
- photo_geotagging (30967)
- photoadjust (30964)
- public_transport (30892)
- reltoolbox (31056)
- reverter (30990)
- tag2link (30962)
- terracer (30892)
- turnrestrictions (31034)
- undelete (30892)
- utilsplugin2 (31040)
- wikipedia (31035)

Last errors/warnings:
- W: org.openstreetmap.josm.io.OsmTransferException: Verbindung zum OSM-Server fehlgeschlagen. Bitte prüfen Sie Ihre Internetverbindung.. Ursache: java.net.NoRouteToHostException: No route to host: connect
- E: java.net.NoRouteToHostException: No route to host: connect
- W: org.openstreetmap.josm.io.OsmTransferException: Verbindung zum OSM-Server fehlgeschlagen. Bitte prüfen Sie Ihre Internetverbindung.. Ursache: java.net.NoRouteToHostException: No route to host: connect
- E: java.net.NoRouteToHostException: No route to host: connect
- W: org.openstreetmap.josm.io.OsmTransferException: Verbindung zum OSM-Server fehlgeschlagen. Bitte prüfen Sie Ihre Internetverbindung.. Ursache: java.net.NoRouteToHostException: No route to host: connect

Attachments (0)

Change History (6)

comment:1 Changed 6 years ago by skyper

Description: modified (diff)

+1 for man_made=embankment

+0 for embankment=yes

  • a way without addition tags should be changed to man_made (warning + auto-fix)
  • there is no problem with embankment=both/left/right if used as additional tag to a primary key
    • similar is true for cutting=*
Last edited 6 years ago by skyper (previous) (diff)

comment:2 Changed 6 years ago by Klumbumbus

Replying to skyper:

  • a way without addition tags should be changed to man_made (warning + auto-fix)

I think there is no consensus about this. embankment=yes without highway|railway|waterway is currently displayed only to the right side of the way. So we should ony warn about direction dependency if highway|railway|waterway is not present at embankment=yes!?

comment:3 Changed 6 years ago by skyper

Summary: add warning for way drirection change of `man_made_embankment` and `embankment=yes`add warning for way direction change of `man_made_embankment` and `embankment=yes`

comment:4 Changed 6 years ago by Klumbumbus

Milestone: 15.0315.04

comment:5 Changed 6 years ago by stoecker

Milestone: 15.0415.05

comment:6 Changed 6 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8408/josm:

fix #11246 - add warning for way direction change of man_made_embankment

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.