Modify

Opened 5 years ago

Closed 3 weeks ago

#11232 closed enhancement (fixed)

Validator should complain about "highway=*; construction=yes"

Reported by: mkoniecz Owned by: team
Priority: normal Milestone: 20.02
Component: Core validator Version:
Keywords: template_report Cc:

Description (last modified by mkoniecz)

What steps will reproduce the problem?

  1. create way
  2. add highway=motorway and construction=yes
  3. run validator

What is the expected result?

Validator complains ("highway=construction, construction=* is a superior tagging scheme to highway=* construction=yes").

What happens instead?

Nothing.

Please provide any additional information below. Attach a screenshot if possible.

In #11146 I was asking for validator rule with an automated fix that is currently impossible to nicely implement. Here I am asking just for message from validator.

There are two methods for mapping road under construction[1]. One is [highway=construction; construction=*], second is [highway=*; construction=yes].

First method is significantly better as it is easier to process and not processing construction-related values is not resulting in wrong data (fail-safe tagging).

In addition construction=yes is used 3366 times with highway=*, highway=construction is used 79730 times[2].

[highway=construction; construction=*] also has wider support (for examples see JOSM and default map style).

[1]http://wiki.openstreetmap.org/wiki/Key:construction
[3]http://taginfo.openstreetmap.org/tags/highway=constructionhttp://taginfo.openstreetmap.org/tags/construction=yes#combinations

Revision: 8133
Repository Root: http://josm.openstreetmap.de/svn
Relative URL: ^/trunk
Last Changed Author: bastiK
Last Changed Date: 2015-03-12 23:37:24 +0100 (Thu, 12 Mar 2015)
Build-Date: 2015-03-13 02:31:01
URL: http://josm.openstreetmap.de/svn/trunk
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Last Changed Rev: 8133

Identification: JOSM/1.5 (8133 en) Linux Ubuntu 14.04.2 LTS
Memory Usage: 425 MB / 889 MB (174 MB allocated, but free)
Java version: 1.8.0_40, Oracle Corporation, Java HotSpot(TM) Server VM
Dataset consistency test: No problems found

Plugins:
- FastDraw (30892)
- OpeningHoursEditor (30962)
- PicLayer (30962)
- buildings_tools (30955)
- continuosDownload (1413902943)
- geotools (31000)
- jts (31002)
- log4j (30892)
- measurement (30892)
- undelete (30892)
- wikipedia (31035)

Attachments (0)

Change History (3)

comment:1 Changed 5 years ago by mkoniecz

Description: modified (diff)

comment:2 Changed 4 weeks ago by Klumbumbus

Milestone: 20.02

We can warn about construction=yes but suggest both possible solutions, construction=minor or highway=construction + construction=*

comment:3 Changed 3 weeks ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 15831/josm:

Fix #11232 - Warn about highway=* + construction=yes

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.