Modify

Opened 5 years ago

Closed 5 years ago

#11104 closed enhancement (fixed)

Test incomplete objects

Reported by: naoliv Owned by: team
Priority: normal Milestone: 15.02
Component: Core validator Version:
Keywords: Cc:

Description

We are adding some tests for incomplete objects in OSM (commonly included in OSM by new users):

*[area][eval(number_of_tags()) = 1],
*[lanes][eval(number_of_tags()) = 1],
*[maxspeed][eval(number_of_tags()) = 1],
*[name][eval(number_of_tags()) = 1],
*[oneway][eval(number_of_tags()) = 1],
*[ref][eval(number_of_tags()) = 1]
*[surface][eval(number_of_tags()) = 1] {
        throwWarning: tr("incomplete object: only {0}", "{0.key}");
}


*[name][area][eval(number_of_tags()) = 2],
*[name][ref][eval(number_of_tags()) = 2],
*[name][surface][eval(number_of_tags()) = 2] {
        throwWarning: tr("incomplete object: only {0} and {1}", "{0.key}", "{1.key}");
}

Is it interesting to include in JOSM? (with a better warning message, etc)

Attachments (0)

Change History (4)

comment:1 Changed 5 years ago by Klumbumbus

Milestone: 15.02

maxspeed already has a warning

only surface, is this really a common error case?

comment:2 Changed 5 years ago by naoliv

If I did it right, there are in Brazil:
21 ways and 120 nodes with surface only
6 ways and 163 nodes with surface + source
19 ways with surface + area

Let's not consider it common then.

I need to have some better sleep, time and everything else to make some stats for the rest.

But for sure we always see new users including:
area
name
name + area

Could the 3 at least (and for now) be considered?

comment:3 Changed 5 years ago by Klumbumbus

lanes also has a test already.

comment:4 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 8054/josm:

fix #11104 - add validator tests for incomplete objects (modified patch by naoliv)

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.