install and load plugins without restart

[bastiK]

It should be possible to install and load plugins without a restart of JOSM.

Status of Plugins

[bastiK]

In 8017/josm:

see #11090 - basic support for plugin loading at runtime.

This is still in testing stage. It will be announced on
the mailing list when plugin authors can start to adapt
their code.

[bastiK]

In [o30952] - see ​#josm11090 - add Manifest property that indicates the plugin can load at runtime

[bastiK]

In [o30953]: see ​#josm11090 - reverter plugin is ready for load at runtime

[bastiK]

In 8020/josm:

see #11090 - make sure modifications to the current MapFrame are done when loading plugin at runtime

[bastiK]

In [o30955]: see ​​#josm11090 - building_tools: add Manifest property that indicates the plugin can load at runtime

[bastiK]

In 8024/josm:

see #11090 - make sure plugin preference tab is shown after runtime load

[bastiK]

In [o30958]: see ​​#josm11090 - utilsplugin2 is ready for load at runtime

[bastiK]

In 8029/josm:

see #11090 - new option for LayerChangeListener to get an initial
notification when the LayerChangeListener is added

[bastiK]

In [o30962]: see ​​​#josm11090 - plugins ready for load at runtime:

OpeningHoursEditor, mirrored_download, photo_geotagging, photoadjust,
piclayer, roadsigns, simplifyarea, tag2link, turnrestrictions

[Don-vip]

Ticket #6396 has been marked as a duplicate of this ticket.

[bastiK]

Replying to Don-vip:

Ticket #6396 has been marked as a duplicate of this ticket.

#6396 is about reloading plugins at runtime, i.e. first unloading it and then loading it again. This is a much more ambitious project and beyond the scope of the current ticket. olejorgenb provided a patch that proves it is technically possible, but I think a lot more "boring" stuff would need to be done before it worked properly.

[bastiK]

In 8030/josm:

see #11090 - refresh plugin info after download & before loading

[Don-vip]

Replying to bastiK:

#6396 is about reloading plugins at runtime, i.e. first unloading it and then loading it again. This is a much more ambitious project and beyond the scope of the current ticket. olejorgenb provided a patch that proves it is technically possible, but I think a lot more "boring" stuff would need to be done before it worked properly.

OK :)

[pwoelfel]

Areaselector plugin has been updated to ​v1.9.0 on ​github.

[Klumbumbus]

It would be nice if also the table at Plugins displays if the plugin supports "install without restart". With this more prominent display it would maybe push some plugin developpers to update their plugin.

[malcolmh]

SeaMapEditor (smed) updated & tested. New version published.

[bastiK]

In [8074]:
#11090 - do not load plugins unless depenencies can be loaded
(or are already loaded)

[Don-vip]

I have some problems to make it work with opendata [o31004:31009]. I have a reentrant call to the EDT when the plugin is loaded at runtime and I'm not sure ho to fix it.

[bastiK]

Replying to Don-vip:

I have some problems to make it work with opendata [o31004:31009]. I have a reentrant call to the EDT when the plugin is loaded at runtime and I'm not sure ho to fix it.

The future.get() in ModuleHandler.loadLocallyAvailableModuleInformation() locks in combination with EventQueue.invokeAndWait(...) in PleaseWaitRunnable.doRealRun().

This has worked before, because the method was only called in main thread, but now the plugins are loaded in EDT. Possible fixes:

• Spawn a background thread to call loadModules() in the OdPlugin constructor
• Don't use PleaseWaitRunnable, but call ReadLocalModuleInformationTask.realRun() directly in ModuleHandler.loadLocallyAvailableModuleInformation()
• Use continuation style like in, e.g. in PluginPreference.UpdateSelectedPluginsAction

[Mkyral]

Hi,
Tracer, Tracer-testing and pointInfo plugins updated, tested and released.

The czechaddress is obsolete as we have working address import from Czech RUIAN database. I'll check the possibility of dropping of the plugin with the Czech community.

[Don-vip]

Replying to Mkyral:

I'll check the possibility of dropping of the plugin with the Czech community.

great! :)

[bastiK]

In [o31021] - utilsplugin2 not working yet

[bastiK]

In [o31023] - fixed utilsplugin2 for load without restart

[bastiK]

Replying to Klumbumbus:

It would be nice if also the table at Plugins displays if the plugin supports "install without restart". With this more prominent display it would maybe push some plugin developpers to update their plugin.

Good idea, done!

[Don-vip]

Replying to bastiK:

In [o31023] - fixed utilsplugin2 for load without restart

This should be commented better as it is not obvious when reading it, that installAdapters() must be called this way to avoid problems. I think anyone could accidentally revert this change.

[bastiK]

Replying to Don-vip:

Replying to bastiK:

In [o31023] - fixed utilsplugin2 for load without restart

This should be commented better as it is not obvious when reading it, that installAdapters() must be called this way to avoid problems. I think anyone could accidentally revert this change.

Alright :) (In [o31026])

[rickmastfan67]

Will doing all this work for making plugins to be loaded without a restart possibly help fix #6725?

[stoecker]

Replying to bastiK:

Replying to Klumbumbus:

It would be nice if also the table at Plugins displays if the plugin supports "install without restart". With this more prominent display it would maybe push some plugin developpers to update their plugin.

Good idea, done!

Could you please use the old design method again? You new design of the tables wastes so much padding space, that the table becomes nearly unreadable even on my large screens.

[bastiK]

Replying to stoecker:

Could you please use the old design method again? You new design of the tables wastes so much padding space, that the table becomes nearly unreadable even on my large screens.

I don't see how you can change the background color in the simple syntax.

pipe style:

some
example

html style:

some
example

[bastiK]

Replying to rickmastfan67:

Will doing all this work for making plugins to be loaded without a restart possibly help fix #6725?

Nope, this is unrelated.

[stoecker]

Replying to bastiK:

Replying to stoecker:

Could you please use the old design method again? You new design of the tables wastes so much padding space, that the table becomes nearly unreadable even on my large screens.

I don't see how you can change the background color in the simple syntax.

Use this trick:

​http://trac-hacks.org/browser/translatedpagesmacro/0.11/translatedpages/translatedpages.py#L369
​http://trac-hacks.org/browser/translatedpagesmacro/0.11/translatedpages/translatedpages.py#L445

Generate the table normal and change color with a regexp before passing the HTML back.

[bastiK]

Should be fixed.

[stoecker]

Replying to bastiK:

Should be fixed.

Fine. I also fixed the icon meta data a bit to say yes/no instead of a useless link :-)

[anonymous]

Plugin ​scripting - done.

[anonymous]

Plugin ​contourmerge - Done

[Rub21]

Plugin ​​tofix - Done!