#11019 closed enhancement (fixed)
Add "brand" to bicycle_repair_station
Reported by: | brycenesbitt | Owned by: | team |
---|---|---|---|
Priority: | minor | Milestone: | 15.02 |
Component: | Internal preset | Version: | latest |
Keywords: | bicycle | Cc: |
Description (last modified by )
The "brand" of bicycle repair station has emerged as an import tag, would it be possible to get that in?
I also ask for reconsideration on "chaintool". That's now supported in iD,
and will be part of an import http://wiki.openstreetmap.org/wiki/Import/Dero_Bike_Repair
-
data/defaultpresets.xml
2599 2599 <space /> 2600 2600 <key key="amenity" value="bicycle_repair_station" /> 2601 2601 <optional> 2602 <reference ref="name_operator_oh" /> 2603 <check key="service:bicycle:pump" text="Free bicycle pump" /> 2602 <text key="operator" text="Operated by" /> 2603 <text key="brand" text="Made by" /> 2604 <check key="service:bicycle:pump" text="Bicycle pump" /> 2605 <check key="service:bicycle:chaintool" text="Tool for repairing chains" /> 2604 2606 </optional> 2605 2607 </item> <!-- Public Bicycle Repair Station --> 2606 2608 </group> <!-- Bicycle -->
Attachments (0)
Change History (19)
comment:1 by , 10 years ago
Description: | modified (diff) |
---|
comment:2 by , 10 years ago
comment:4 by , 10 years ago
The first import took place, but was reverted due to a missed step in the import approval process.
comment:5 by , 10 years ago
What are the numbers of
service:bicycle:chaintool=yes
service:bicycle:chaintool=no
service:bicycle:chaintool
unknown
and
opening_hours
of the Dero source?
comment:6 by , 10 years ago
When considering a preset, which is about future tagging,
I feel the utility of the tags should be considered, not their
present popularity. Presets are about the future not the past!
comment:7 by , 10 years ago
The JOSM internal default presets are to simplify established tagging schemes, not to invent new ones. Atleast this is my understanding and similar documented at DevelopersGuide/DefaultPresets.
"[...] decent usage numbers (absolute and by number of mappers)
If a features is only mapped by a handful of specialists, it is better suited for an external preset. [...]"
Currently there are only 5 nodes with service:bicycle:chaintool
(four of them are from you). So I tried to understand why this is the case. Maybe this key is not needed because all stations have a chaintool or no station has a chaintool. Or other reasons. So this is why I asked for the numbers, to understand the whole situation better.
I asked for the opening hours, because I was thinking about setting 24/7 as default value.
comment:8 by , 10 years ago
There is always the option to create external presets especially for new and/or rarely used tags.
comment:9 by , 10 years ago
24/7 is by far the most common value for opening_hours.
The other common value is "destination", for stations in places like subway stops.
Chaintools seem to be rare: none of the three major vendors include one:
http://guides.obviously.com/Public-Bicycle-Work-and-Repair-Stands-2/1925
Thus the Dero import will have all those set to "no". Yet, if my chain is broken, I'll want to search for "yes".
There appear to be (based on sales figures) at least 4,000 manufactured stations worldwide, with
over 2,000 of those placed in the last year.
--
I see the purpose of a preset as helping to standardize tagging among tools, and
help steer a user into collecting useful data for a given feature.
comment:11 by , 10 years ago
Milestone: | → 15.02 |
---|
Shouldn't it be service:bicycle:chain_tool
because "chain tool" are two words?
follow-up: 13 comment:12 by , 10 years ago
I think you're right about chain tool: http://en.wikipedia.org/wiki/Chain_tool
But if so it should be changed everywhere, not just the JOSM preset.
comment:13 by , 10 years ago
Replying to brycenesbitt:
But if so it should be changed everywhere, not just the JOSM preset.
Yes, with only 6 uses, I think it is not to late, to change it without big problems. But you should maybe inform the other two people if you change the key. http://overpass-turbo.eu/s/7Cx
comment:14 by , 10 years ago
Ok, "mass retagging" done.
Now on to the iD preset.
And 24/7 is definitely the most common value: a good choice of default. The only other reasonably common value is "destination" for train stations.
comment:15 by , 10 years ago
Milestone: | 15.02 → 15.03 |
---|
comment:17 by , 10 years ago
Milestone: | 15.03 → 15.02 |
---|
comment:18 by , 10 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:19 by , 10 years ago
The repair station import is underway, and complete for the western USA.
Unfortunately some people are using iD's preset to tag bike shops as repair stations. Sigh.
Brand and chaintool are now part of the iD preset.