Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#11019 closed enhancement (fixed)

Add "brand" to bicycle_repair_station

Reported by: brycenesbitt Owned by: team
Priority: minor Milestone: 15.02
Component: Internal preset Version: latest
Keywords: bicycle Cc:

Description (last modified by Klumbumbus)

The "brand" of bicycle repair station has emerged as an import tag, would it be possible to get that in?

I also ask for reconsideration on "chaintool". That's now supported in iD,
and will be part of an import http://wiki.openstreetmap.org/wiki/Import/Dero_Bike_Repair

  • data/defaultpresets.xml

     
    25992599            <space />
    26002600            <key key="amenity" value="bicycle_repair_station" />
    26012601            <optional>
    2602             <reference ref="name_operator_oh" />
    2603             <check key="service:bicycle:pump" text="Free bicycle pump" />
     2602            <text  key="operator" text="Operated by" />
     2603            <text  key="brand"    text="Made by" />
     2604            <check key="service:bicycle:pump"      text="Bicycle pump" />
     2605            <check key="service:bicycle:chaintool" text="Tool for repairing chains" />
    26042606            </optional>
    26052607        </item> <!-- Public Bicycle Repair Station -->
    26062608    </group> <!-- Bicycle -->

Attachments (0)

Change History (19)

comment:1 Changed 5 years ago by Klumbumbus

Description: modified (diff)

comment:2 Changed 5 years ago by brycenesbitt

Brand and chaintool are now part of the iD preset.

comment:3 Changed 5 years ago by Klumbumbus

When will the first import take place?

comment:4 Changed 5 years ago by brycenesbitt

The first import took place, but was reverted due to a missed step in the import approval process.

comment:5 Changed 5 years ago by Klumbumbus

What are the numbers of

service:bicycle:chaintool=yes
service:bicycle:chaintool=no
service:bicycle:chaintool unknown

and

opening_hours

of the Dero source?

comment:6 Changed 5 years ago by brycenesbitt

When considering a preset, which is about future tagging,
I feel the utility of the tags should be considered, not their
present popularity. Presets are about the future not the past!

comment:7 Changed 5 years ago by Klumbumbus

The JOSM internal default presets are to simplify established tagging schemes, not to invent new ones. Atleast this is my understanding and similar documented at DevelopersGuide/DefaultPresets.

"[...] decent usage numbers (absolute and by number of mappers)
If a features is only mapped by a handful of specialists, it is better suited for an external preset. [...]"

Currently there are only 5 nodes with service:bicycle:chaintool (four of them are from you). So I tried to understand why this is the case. Maybe this key is not needed because all stations have a chaintool or no station has a chaintool. Or other reasons. So this is why I asked for the numbers, to understand the whole situation better.

I asked for the opening hours, because I was thinking about setting 24/7 as default value.

comment:8 Changed 5 years ago by skyper

There is always the option to create external presets especially for new and/or rarely used tags.

comment:9 Changed 5 years ago by brycenesbitt

24/7 is by far the most common value for opening_hours.
The other common value is "destination", for stations in places like subway stops.

Chaintools seem to be rare: none of the three major vendors include one:
http://guides.obviously.com/Public-Bicycle-Work-and-Repair-Stands-2/1925
Thus the Dero import will have all those set to "no". Yet, if my chain is broken, I'll want to search for "yes".

There appear to be (based on sales figures) at least 4,000 manufactured stations worldwide, with
over 2,000 of those placed in the last year.

--
I see the purpose of a preset as helping to standardize tagging among tools, and
help steer a user into collecting useful data for a given feature.

comment:10 Changed 5 years ago by Klumbumbus

In 8019/josm:

see #11019 - improve amenity=bicycle_repair_station preset

comment:11 Changed 5 years ago by Klumbumbus

Milestone: 15.02

Shouldn't it be service:bicycle:chain_tool because "chain tool" are two words?

comment:12 Changed 5 years ago by brycenesbitt

I think you're right about chain tool: http://en.wikipedia.org/wiki/Chain_tool
But if so it should be changed everywhere, not just the JOSM preset.

comment:13 in reply to:  12 Changed 5 years ago by Klumbumbus

Replying to brycenesbitt:

But if so it should be changed everywhere, not just the JOSM preset.

Yes, with only 6 uses, I think it is not to late, to change it without big problems. But you should maybe inform the other two people if you change the key. http://overpass-turbo.eu/s/7Cx

comment:14 Changed 5 years ago by brycenesbitt

Ok, "mass retagging" done.
Now on to the iD preset.

And 24/7 is definitely the most common value: a good choice of default. The only other reasonably common value is "destination" for train stations.

Last edited 5 years ago by brycenesbitt (previous) (diff)

comment:15 Changed 5 years ago by Don-vip

Milestone: 15.0215.03

comment:16 Changed 5 years ago by Klumbumbus

In 8107/josm:

see #11019 - improve amenity=bicycle_repair_station preset

comment:17 Changed 5 years ago by Klumbumbus

Milestone: 15.0315.02

comment:18 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

comment:19 Changed 5 years ago by brycenesbitt

The repair station import is underway, and complete for the western USA.
Unfortunately some people are using iD's preset to tag bike shops as repair stations. Sigh.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.