Opened 10 years ago

Closed 10 years ago

#10955 closed defect (invalid)

Uploading change-set with DELETE actions results in empty changeset (JOSM guru needed) — at Version 2

Reported by: brycenesbitt Owned by: team
Priority: normal Milestone:
Component: Core Version: latest
Keywords: Cc:

Description (last modified by Don-vip)

The following file when uploaded via JOSM results in an empty change set:

<?xml version='1.0' encoding='UTF-8'?>
<osm version='0.6' generator='Osmsync_CCS'>
<note>test</note>
<node action='delete' id='1409407267' version='2'
user='Bryce C Nesbitt' uid='355242' changeset='9241456'
timestamp='2011-09-07T22:22:05Z'>
</node>
</osm>

The procedure is:
1) Load "ccs.osm" into JOSM.
2) Observe JOSM reports one deleted node. Press upload, note JOSM says one node will be deleted.
3) Note the changeset number. Check the changeset on the server side, and note it is empty.
4) Note the node (here http://www.openstreetmap.org/node/1409407267 ) is untouched.

The node to be deleted is marked as "incomplete" in AbstractPrimative/setIncomplete(), though it is not clear why. Adding or removing properties from the delete action above seems to make no difference.


My goal is to use JOSM for human review of changes prior to final upload to the osm servers. The actions "add" and "update" work fine, only "delete" does not.

JOSM is good for this task, but not ideal, due to limited ways to highlight deleted data.

Change History (3)

by brycenesbitt, 10 years ago

Attachment: ccs.osm added

File meant to load into JOSM, resulting in deletion of a node.

comment:1 by brycenesbitt, 10 years ago

Description: modified (diff)

comment:2 by Don-vip, 10 years ago

Description: modified (diff)
Resolution: invalid
Status: newclosed

JOSM does not know all required info about this node. If you delete this node from JOSM and save your data to an .osm file you will have this output:

<?xml version='1.0' encoding='UTF-8'?>
<osm version='0.6' upload='true' generator='JOSM'>
  <node id='1409407267' action='delete' timestamp='2011-09-07T22:22:05Z' uid='355242' user='Bryce C Nesbitt' visible='true' version='2' changeset='9241456' lat='37.779177' lon='-122.418272'>
    <tag k='amenity' v='car_sharing' />
    <tag k='capacity' v='1' />
    <tag k='description' v='56 Dr Carlton B Goodlett Place with Toyota Prius Plugin Hybrid' />
    <tag k='name' v='San Francisco/Civic Center: Polk &amp; Grove (Green Vehicle Showcase)' />
    <tag k='operator' v='City CarShare' />
    <tag k='source' v='osmsync:ccs' />
    <tag k='source:pkey' v='192' />
    <tag k='website' v='http://www.citycarshare.org/pod_192.do' />
  </node>
</osm>

The tags might be optional (TBC, I did not test), but the lat, lon and visible attributes are required to make JOSM consider this node as complete.

So you need to update the "Osmsync_CCS" generator to comply with format expected by JOSM.

Note: See TracTickets for help on using tickets.