Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10941 closed defect (fixed)

rows parameter in multiselect in preset not working

Reported by: JanVanBekkum Owned by: team
Priority: normal Milestone: 15.01
Component: Core Version: tested
Keywords: preset multiselect rows Cc:

Description

What steps will reproduce the problem?

  1. Create a line <text key="description" text="Description" default="" delete_if_empty="true" rows="3" /> in a preset file
  2. Observe the number of rows when the preset is used
  3. See attached preset file

What is the expected result?

Number of rows as specified

What happens instead?

One row in one example, eight rows in another one.

Please provide any additional information below. Attach a screenshot if possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-09 17:17:36
Last Changed Author: Don-vip
Revision: 7777
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-09 18:14:49 +0100 (Tue, 09 Dec 2014)
Last Changed Rev: 7777

Identification: JOSM/1.5 (7777 en) Windows 8 64-Bit
Memory Usage: 384 MB / 910 MB (283 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- reverter (30737)
- turnrestrictions (30762)

Last errors/warnings:
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'

Attachments (1)

Presets_Camp_site_extends-preset.zip (1.3 KB) - added by JanVanBekkum 5 years ago.

Download all attachments as: .zip

Change History (9)

Changed 5 years ago by JanVanBekkum

comment:1 Changed 5 years ago by Klumbumbus

According to TaggingPresets rows=* is only for <multiselect>, not for <text>.

For <multiselect> it seems it ignores rows=* and uses always 8 rows.

comment:2 Changed 5 years ago by Klumbumbus

Two offtopic notes to your preset:

  • delete_if_empty="true" was removed. you can just delete it.
  • default value of a check is "off" and for text, combo ans multiselect "", so no need to specify this again in your preset code

comment:3 Changed 5 years ago by JanVanBekkum

Thanks

comment:4 Changed 5 years ago by Don-vip

Keywords: multiselect rows added; text field removed
Milestone: 15.01
Summary: rows parameter in text key in preset not workingrows parameter in multiselect in preset not working

comment:5 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7931/josm:

fix #10941 - fix handling of rows attribute for multiselect preset item

comment:6 Changed 5 years ago by Klumbumbus

So, the default value of rows, if not specified is 8, right?

comment:7 Changed 5 years ago by Don-vip

I believe we do not set any default value and it will be determined by java or the look and feel.

comment:8 Changed 5 years ago by Klumbumbus

ah, ok.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.