rows parameter in multiselect in preset not working

[JanVanBekkum]

What steps will reproduce the problem?

1. Create a line <text key="description" text="Description" default="" delete_if_empty="true" rows="3" /> in a preset file
2. Observe the number of rows when the preset is used
3. See attached preset file

What is the expected result?

Number of rows as specified

What happens instead?

One row in one example, eight rows in another one.

Please provide any additional information below. Attach a screenshot if possible.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-09 17:17:36
Last Changed Author: Don-vip
Revision: 7777
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-09 18:14:49 +0100 (Tue, 09 Dec 2014)
Last Changed Rev: 7777

Identification: JOSM/1.5 (7777 en) Windows 8 64-Bit
Memory Usage: 384 MB / 910 MB (283 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- reverter (30737)
- turnrestrictions (30762)

Last errors/warnings:
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'
- E: Failed to locate image 'Campground'

[Klumbumbus]

According to TaggingPresets rows=* is only for <multiselect>, not for <text>.

For <multiselect> it seems it ignores rows=* and uses always 8 rows.

[Klumbumbus]

Two offtopic notes to your preset:

• delete_if_empty="true" was removed. you can just delete it.
• default value of a check is "off" and for text, combo ans multiselect "", so no need to specify this again in your preset code

[JanVanBekkum]

Thanks

[Don-vip]

In 7931/josm:

fix #10941 - fix handling of rows attribute for multiselect preset item

[Klumbumbus]

So, the default value of rows, if not specified is 8, right?

[Don-vip]

I believe we do not set any default value and it will be determined by java or the look and feel.

[Klumbumbus]

ah, ok.