[patch] bicycle_repair_station preset and icon

[brycenesbitt]

Here's a preset for bicycle_repair_station with an icon.

If you're ever out cycling, and have a problem, you'll want one of these.
Note that some of them are associated with vending machines for tubes and patch kits.

[Klumbumbus]

Replying to brycenesbitt:

Note I would have preferred to use "<check>" rather than "<combo>",
but I could not figure out how to support entering a negative like
"Pump=no".

A check has three states: key not set, yes and no.

[Klumbumbus]

The keys make_model=* and service:bicycle:chaintool=* and not well documented in the wiki and not widely used. So they do not fulfill the requirements for the internal preset. See DevelopersGuide/DefaultPresets. indoor=* is also not documented and controversial.

service:bicycle:diy doens't make sense to me, since such a bicycle repair station is always diy. Otherwise it would be shop=bicycle + service:bicycle:repair=yes.

Can you provide a svg icon with both a bicycle and a wrench (maybe similar to amenity=bicycle_rental)? Also make sure, that it is visible on black background and license compatible, see DevelopersGuide/DefaultPresets#NewIcons.

[skyper]

Replying to brycenesbitt:

Note I would have preferred to use "<check>" rather than "<combo>",
but I could not figure out how to support entering a negative like
"Pump=no".

See TaggingPresets#Attributeentryandselectiondialogboxes and the paragraph below (TaggingPresets#Attributes). Think you are looking for value_on plus value_off.

[brycenesbitt]

Wrench over bicycle icon, SVG format

[brycenesbitt]

Render wrench and bike in white, with a transparent background. To see in inkscape draw a solid color shape behind this.

[brycenesbitt]

Removed indoor, used check

[brycenesbitt]

Removed indoor, used <check>

[brycenesbitt]

• Updated the icon. It is licence compatible.
• Removed the DIY tag. I was following practice, but it does not make any sense.
• Recolored the icon to white.
• Moved to using <check>