Modify

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#10900 closed enhancement (fixed)

[patch] bicycle_repair_station preset and icon

Reported by: brycenesbitt Owned by: team
Priority: normal Milestone: 15.01
Component: Internal preset Version:
Keywords: Cc:

Description (last modified by brycenesbitt)

Here's a preset for bicycle_repair_station with an icon.

If you're ever out cycling, and have a problem, you'll want one of these.
Note that some of them are associated with vending machines for tubes and patch kits.

Attachments (7)

wrench-icon.png (6.2 KB) - added by brycenesbitt 4 years ago.
wrench-icon.svg (873 bytes) - added by brycenesbitt 4 years ago.
wrench-bike-icon.svg (5.5 KB) - added by brycenesbitt 4 years ago.
Wrench over bicycle icon, SVG format
wrench-bike-icon_24x24.png (1.0 KB) - added by brycenesbitt 4 years ago.
wrench-bike-icon-white.svg (5.4 KB) - added by brycenesbitt 4 years ago.
Render wrench and bike in white, with a transparent background. To see in inkscape draw a solid color shape behind this.
bicycle_repair_station.2.diff (1.5 KB) - added by brycenesbitt 4 years ago.
Removed indoor, used check
bicycle_repair_station.diff (1.5 KB) - added by brycenesbitt 4 years ago.
Removed indoor, used <check>

Download all attachments as: .zip

Change History (20)

Changed 4 years ago by brycenesbitt

Attachment: wrench-icon.png added

Changed 4 years ago by brycenesbitt

Attachment: wrench-icon.svg added

comment:1 Changed 4 years ago by brycenesbitt

Summary: PATCH: bicycle_repair_station preset and icon[patch] bicycle_repair_station preset and icon

comment:2 in reply to:  description Changed 4 years ago by Klumbumbus

Replying to brycenesbitt:

Note I would have preferred to use "<check>" rather than "<combo>",
but I could not figure out how to support entering a negative like
"Pump=no".

A check has three states: key not set, yes and no.

comment:3 Changed 4 years ago by Klumbumbus

Milestone: 15.01

The keys make_model=* and service:bicycle:chaintool=* and not well documented in the wiki and not widely used. So they do not fulfill the requirements for the internal preset. See DevelopersGuide/DefaultPresets. indoor=* is also not documented and controversial.

service:bicycle:diy doens't make sense to me, since such a bicycle repair station is always diy. Otherwise it would be shop=bicycle + service:bicycle:repair=yes.

Can you provide a svg icon with both a bicycle and a wrench (maybe similar to amenity=bicycle_rental)? Also make sure, that it is visible on black background and license compatible, see DevelopersGuide/DefaultPresets#NewIcons.

comment:4 in reply to:  description Changed 4 years ago by skyper

Replying to brycenesbitt:

Note I would have preferred to use "<check>" rather than "<combo>",
but I could not figure out how to support entering a negative like
"Pump=no".

See TaggingPresets#Attributeentryandselectiondialogboxes and the paragraph below (TaggingPresets#Attributes). Think you are looking for value_on plus value_off.

Changed 4 years ago by brycenesbitt

Attachment: wrench-bike-icon.svg added

Wrench over bicycle icon, SVG format

Changed 4 years ago by brycenesbitt

Attachment: wrench-bike-icon_24x24.png added

Changed 4 years ago by brycenesbitt

Attachment: wrench-bike-icon-white.svg added

Render wrench and bike in white, with a transparent background. To see in inkscape draw a solid color shape behind this.

Changed 4 years ago by brycenesbitt

Removed indoor, used check

Changed 4 years ago by brycenesbitt

Attachment: bicycle_repair_station.diff added

Removed indoor, used <check>

comment:5 Changed 4 years ago by brycenesbitt

  • Updated the icon. It is licence compatible.
  • Removed the DIY tag. I was following practice, but it does not make any sense.
  • Recolored the icon to white.
  • Moved to using <check>

comment:6 Changed 4 years ago by brycenesbitt

Description: modified (diff)

comment:7 Changed 4 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 7928/josm:

fix #10900 - add amenity=bicycle_repair_station to preset and mappaintstyle (patch by brycenesbitt, modified)

comment:8 Changed 4 years ago by Klumbumbus

The default values of a check are yes and no, so no need for value_on and value_off in this case.

Icon added in [o30898]

Icons with transparent background must not be only black or only white. Otherwise if one uses a black or white background (no aerial imagery as background) in the Map View black or white icons would be invisible.

comment:9 Changed 4 years ago by Klumbumbus

In 7930/josm:

see #10900 - typo

comment:10 in reply to:  3 ; Changed 4 years ago by aceman

Replying to Klumbumbus:

The keys make_model=* and service:bicycle:chaintool=* and not well documented in the wiki and not widely used. So they do not fulfill the requirements for the internal preset. See DevelopersGuide/DefaultPresets. indoor=* is also not documented and controversial.

Does this whole amenity=bicycle_repair_station requirements for internal preset? It is used only 52 times in the whole world. So what are the rules?

comment:11 in reply to:  10 Changed 4 years ago by Klumbumbus

Replying to aceman:

So what are the rules?

See the link in your quote. No hard rules, more guidelines. There are maybe not so much mapped, because there do not exist so much (like aerialway_mixed_lift). There is not another tag for the same feature and a discussion, which tag to use. So, I don't see a reason not to include amenity=bicycle_repair_station into the default preset.

comment:12 Changed 4 years ago by brycenesbitt

It belongs in part because there's no alternative. People are mapping these now using bike rack of capacity 1, or a shop that does not sell bikes, to get them to render.

The question is not how many are mapped now, but how many there are to map and how important they are.
By that measure this is a great feature, especially if you happen to have a broken chain or loose handlebar on YOUR bike when you're travelling.

comment:13 in reply to:  12 Changed 4 years ago by aceman

Replying to brycenesbitt:

The question is not how many are mapped now, but how many there are to map and how important they are.

One point on the guidelines page mentions there should be a reasonable number of uses.

So you say the feature is very important, but people are not mapping it, or mapping it using other tags. And people will start mapping it correctly just because JOSM will have a preset for it?

Can you show on taginfo how many of those "other tags" actually mean amenity=bicycle_repair_station ? And want to be converted to it once it is available.

I think the guidelines were used so far to not put presets into JOSM about unused features. First the usage numbers had to show what the people really want (and tag). Not JOSM dictating what NEW tags people should suddenly use.

I do not dispute the usefulness of showing these facilities to BIKERS in the field. I just want the see any support for the claim that MAPPERS want to use the exact tag "amenity=bicycle_repair_station". That the wiki page for the tag (as draft) exists for 6 months and there are only 52 uses of it would indicate the opposite of your claim. Mappers could start using it long ago if they actually wanted.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.