Validator rule: change needed for junction=yes

[sommerluk]

If you apply junction=yes on an OSM way without a “highway” key, the validator (before uploading to OSM) throws an error message: “junction without highway”. While this is fine for the “junction” key in general (junction=roundabout and so on), for the specific case of junction=yes this should not be checked (or, even better, do the opposite: throw an error if junction=yes and a “highway” key are on the same element).

[Don-vip]

can you please attach (or link) a real-world example? Thanks.

[sommerluk]

demo.osm

[sommerluk]

Link to real-world-usage (same element as in demo.osm):

​https://www.openstreetmap.org/way/314765777

[sommerluk]

If you want, I can produce a “clean” .osm file just for demonstration (not taken from OSM database)…

[Don-vip]

it's perfect thanks! Okay I didn't know this form of tagging.

[Klumbumbus]

Replying to sommerluk:

(or, even better, do the opposite: throw an error if junction=yes and a “highway” key are on the same element).

Would be wrong on nodes (e.g. highway=traffic_signals, junction=yes)

[Don-vip]

In 7905/josm:

fix #10896 - false positive for junction=yes without highway

[Klumbumbus]

Replying to Don-vip:

In 7905/josm:

fix #10896 - false positive for junction=yes without highway

This will trigger the warning also for ways tagged with e.g. a=b

[Don-vip]

Woups. I was pretty sure the syntax [key!=value] implied the presence of key, looks like I'm wrong.

[Don-vip]

In 7906/josm:

fix #10896 - fix last commit