Modify

Opened 5 years ago

Closed 5 years ago

#10896 closed defect (fixed)

Validator rule: change needed for junction=yes

Reported by: sommerluk Owned by: team
Priority: normal Milestone: 14.12
Component: Core validator Version:
Keywords: Cc:

Description

If you apply junction=yes on an OSM way without a “highway” key, the validator (before uploading to OSM) throws an error message: “junction without highway”. While this is fine for the “junction” key in general (junction=roundabout and so on), for the specific case of junction=yes this should not be checked (or, even better, do the opposite: throw an error if junction=yes and a “highway” key are on the same element).

Attachments (1)

demo.osm (30.4 KB) - added by sommerluk 5 years ago.
demo.osm

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by Don-vip

Owner: changed from team to sommerluk
Status: newneedinfo

can you please attach (or link) a real-world example? Thanks.

Changed 5 years ago by sommerluk

Attachment: demo.osm added

demo.osm

comment:2 Changed 5 years ago by sommerluk

Link to real-world-usage (same element as in demo.osm):

https://www.openstreetmap.org/way/314765777

comment:3 Changed 5 years ago by sommerluk

Owner: changed from sommerluk to team
Status: needinfonew

If you want, I can produce a “clean” .osm file just for demonstration (not taken from OSM database)…

comment:4 Changed 5 years ago by Don-vip

Milestone: 14.12

it's perfect thanks! Okay I didn't know this form of tagging.

comment:5 Changed 5 years ago by Klumbumbus

Component: CoreCore validator

Replying to sommerluk:

(or, even better, do the opposite: throw an error if junction=yes and a “highway” key are on the same element).

Would be wrong on nodes (e.g. highway=traffic_signals, junction=yes)

comment:6 Changed 5 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7905/josm:

fix #10896 - false positive for junction=yes without highway

comment:7 in reply to:  6 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Replying to Don-vip:

In 7905/josm:

fix #10896 - false positive for junction=yes without highway

This will trigger the warning also for ways tagged with e.g. a=b

comment:8 Changed 5 years ago by Don-vip

Woups. I was pretty sure the syntax [key!=value] implied the presence of key, looks like I'm wrong.

comment:9 Changed 5 years ago by Don-vip

Resolution: fixed
Status: reopenedclosed

In 7906/josm:

fix #10896 - fix last commit

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.