Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10868 closed enhancement (fixed)

provide a gui setting for `osm.notes.daysClosed` (was: download also recently closed notes)

Reported by: Klumbumbus Owned by: ToeBee
Priority: normal Milestone: 15.04
Component: Core notes Version:
Keywords: template_report Cc:

Description

The osm website displays closed notes for a while (I don't know exactly how long) after they were closed. The core notes feature should do the same, but it does not download recently closed notes. See note/267716, was closed the day before yesterday but cannot be downloaded with core notes feature.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-17 15:35:00
Last Changed Author: Klumbumbus
Revision: 7819
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-17 15:17:17 +0100 (Wed, 17 Dec 2014)
Last Changed Rev: 7819

Identification: JOSM/1.5 (7819 en) Windows 7 32-Bit
Memory Usage: 273 MB / 742 MB (132 MB allocated, but free)
Java version: 1.7.0_71, Oracle Corporation, Java HotSpot(TM) Client VM
VM arguments: [-Djava.security.manager, -Djava.security.policy=file:C:\Program Files\Java\jre7\lib\security\javaws.policy, -DtrustProxy=true, -Djnlpx.home=<java.home>\bin, -Djnlpx.origFilenameArg=C:\Program Files\josm-latest.jnlp, -Djnlpx.remove=true, -Djava.util.Arrays.useLegacyMergeSort=true, -Djnlpx.heapsize=256m,768m, -Djnlpx.splashport=49611, -Djnlpx.jvm=<java.home>\bin\javaw.exe, -Djnlpx.vmargs=LURqYXZhLnV0aWwuQXJyYXlzLnVzZUxlZ2FjeU1lcmdlU29ydD10cnVlAA==]
Dataset consistency test: No problems found

Plugins:
- DirectUpload (30737)
- HouseNumberTaggingTool (30762)
- OpeningHoursEditor (30737)
- PicLayer (30762)
- Tracer2 (30695)
- buildings_tools (30762)
- download_along (30762)
- editgpx (30737)
- imagery_offset_db (30808)
- measurement (30737)
- mirrored_download (30762)
- public_transport (30762)
- reltoolbox (30841)
- reverter (30737)
- tag2link (30719)
- terracer (30737)
- turnrestrictions (30762)
- undelete (30762)
- utilsplugin2 (30762)
- wikipedia (30780)

Last errors/warnings:
- W: TMS - Failed downloading http://ecn.t1.tiles.virtualearth.net/tiles/a120212032233110.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t1.tiles.virtualearth.net/tiles/a120212032231333.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t3.tiles.virtualearth.net/tiles/a120212032233113.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t2.tiles.virtualearth.net/tiles/a120212032233111.jpeg?g=3089: Attribution is not loaded yet
- W: TMS - Failed downloading http://ecn.t0.tiles.virtualearth.net/tiles/a120212032233102.jpeg?g=3089: Attribution is not loaded yet

Attachments (0)

Change History (13)

comment:1 Changed 5 years ago by ToeBee

osm.org displays notes that were closed within the last week. JOSM currently defaults to downloading notes that were closed within the last 24 hours. However this time period is governed by a preference which you can change in the advanced preferences dialog. Search for osm.notes.daysClosed and set it to 7 for a week, 0 for only open notes or -1 for all notes, ever.

This setting should be exposed via a GUI dialog somewhere though (along with the download limit as mentioned in #10867)

comment:2 in reply to:  1 ; Changed 5 years ago by Klumbumbus

Replying to ToeBee:

osm.notes.daysClosed

There is not such a key in the advanced preferences. Do I need to create it manually?

I think the default value of 1 day is too short. Maybe 7 days as the default value would be fine.

comment:3 in reply to:  2 ; Changed 5 years ago by skyper

Replying to Klumbumbus:

Replying to ToeBee:

osm.notes.daysClosed

There is not such a key in the advanced preferences. Do I need to create it manually?

Yes.

I think the default value of 1 day is too short. Maybe 7 days as the default value would be fine.

+1

comment:4 in reply to:  3 Changed 5 years ago by skyper

Replying to skyper:

Yes.

Keys with default values are not listed.

comment:5 Changed 5 years ago by ToeBee

They aren't shown at startup. Once they are accessed they seem to be shown though. If you download notes once and then go to preferences they should be there.

comment:6 in reply to:  5 Changed 5 years ago by Klumbumbus

Replying to ToeBee:

They aren't shown at startup. Once they are accessed they seem to be shown though. If you download notes once and then go to preferences they should be there.

Ah, yes. Thanks.

comment:7 in reply to:  1 Changed 5 years ago by skyper

Replying to ToeBee:

osm.org displays notes that were closed within the last week. JOSM currently defaults to downloading notes that were closed within the last 24 hours. However this time period is governed by a preference which you can change in the advanced preferences dialog. Search for osm.notes.daysClosed and set it to 7 for a week, 0 for only open notes or -1 for all notes, ever.

This setting should be exposed via a GUI dialog somewhere though (along with the download limit as mentioned in #10867)

I did ask for filters in #9908. As the download method changed, these filter options might be also useful for downloads.

comment:8 Changed 5 years ago by Don-vip

Component: CoreCore notes

Moving notes tickets to their own component

comment:9 Changed 5 years ago by Don-vip

Keywords: notes removed

comment:10 Changed 5 years ago by Klumbumbus

In 8118/josm:

see #10868 - set default value of advanced pref osm.notes.daysClosed from 1 to 7 (like on osm.org)

comment:11 Changed 5 years ago by Klumbumbus

Summary: download also recently closed notesprovide a gui setting for `osm.notes.daysClosed` (was: download also recently closed notes)

comment:12 Changed 5 years ago by simon04

Resolution: fixed
Status: newclosed

In 8218/josm:

fix #10868 - Add osm.notes.daysClosed to preference dialog

comment:13 Changed 5 years ago by simon04

Milestone: 15.04

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.