Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10827 closed defect (fixed)

[patch] Cannot download only notes

Reported by: Zverikk Owned by: ToeBee
Priority: normal Milestone: 14.12
Component: Core notes Version: latest
Keywords: Cc:

Description

  1. Open JOSM, open the download dialog.
  2. Uncheck "Data" and "GPX", enable "Notes".
  3. Select an area and press "Download"

Expected: notes for an area. Instead I've got an error message like "choose either osm data or gpx traces".

Attachments (1)

note_only_download.patch (907 bytes) - added by ToeBee 5 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 5 years ago by stoecker

Owner: changed from team to ToeBee

comment:2 Changed 5 years ago by ToeBee

Yeah, I knew about this. When I initially looked at this logic I thought it would be complicated to implement until the notes feature was enabled for everyone. But looking at it again now I'm not sure why it would be hard. I'll take a closer look tonight.

comment:3 Changed 5 years ago by Don-vip

Milestone: 14.12

comment:4 in reply to:  2 Changed 5 years ago by skyper

Replying to ToeBee:

Yeah, I knew about this. When I initially looked at this logic I thought it would be complicated to implement until the notes feature was enabled for everyone. But looking at it again now I'm not sure why it would be hard. I'll take a closer look tonight.

Thanks, I really need it in my area, cause downloading data/gpx is way to much traffic.

Last edited 5 years ago by skyper (previous) (diff)

comment:5 Changed 5 years ago by ToeBee

Yeah, this is simple after all. I think when I was first putting in the checkbox I wasn't instantiating it at all if notes were disabled which would have required the download check to worry about null. But the way I ended up doing it, it just doesn't get added to the GUI if notes are disabled so the isDownloadNotes check just returns false and everything is happy.

The only slight inconsistency now is the message displayed to the user. If notes are disabled, I don't want it to say anything about notes so I'm leaving the error message alone for now. If notes are enabled and nothing is checked, it will still say you need to select either OSM data or GPX data.

Changed 5 years ago by ToeBee

Attachment: note_only_download.patch added

comment:6 Changed 5 years ago by ToeBee

Status: newassigned
Summary: Cannot download only notes[patch] Cannot download only notes

comment:7 Changed 5 years ago by skyper

This problem effects me even further. On the first time enabled I can not even "comment", "close" or sort notes even after redownloading.

I have to delete the all notes layers in advance and then redownload to fix it.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-15 02:34:17
Last Changed Author: bastiK
Revision: 7804
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-14 16:20:17 +0100 (Sun, 14 Dec 2014)
Last Changed Rev: 7804

Identification: JOSM/1.5 (7804 en) Linux Debian GNU/Linux 7.7 (wheezy)
Memory Usage: 362 MB / 882 MB (86 MB allocated, but free)
Java version: 1.7.0_65, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u71-2.5.3-2~deb7u1
VM arguments: [-Djosm.home=/tmp/.josm_notes2]
Program arguments: [--language=en, --set=osm.notes.enableDownload=true]
Dataset consistency test: No problems found

comment:8 in reply to:  7 Changed 5 years ago by skyper

Replying to skyper:

This problem effects me even further. On the first time enabled I can not even "comment", "close" or sort notes even after redownloading.

I have to delete the all notes layers in advance and then redownload to fix it.

Damn, sorry, wrong ticket, meant #10845.

comment:9 Changed 5 years ago by bastiK

Resolution: fixed
Status: assignedclosed

In 7808/josm:

applied #10827 - Cannot download only notes (patch by ToeBee)

comment:10 Changed 5 years ago by aseerel4c26

Works as expected now (tested with osm.notes.enableDownload =true and =false) tested with Version 7819.

comment:11 Changed 5 years ago by Klumbumbus

Component: CoreCore notes
Keywords: notes removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.