Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10845 closed defect (fixed)

[PATCH] notes downloaded before the notes dialog window was active do not show up in it

Reported by: aseerel4c26 Owned by: ToeBee
Priority: normal Milestone: 14.12
Component: Core notes Version: tested
Keywords: Cc: Klumbumbus

Description

JOSM version: 7777 (sorry, the full report template contains too much personal info!)

  1. set osm.notes.enableDownload to true
  2. make sure the notes dialog window (right side bar) is not loaded
  3. restart josm
  4. download notes and gps traces in an area where there is one note
  5. enable the notes dialog window (via menu view)
  • Actual result: the note does not show up in the dialog window (it only shows up on the JOSM map)
  • Expected: the note shows up in the dialog window (it shows up on the map too)

Thank you!

Attachments (1)

empty_note_dialog.patch (875 bytes) - added by ToeBee 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 in reply to:  description Changed 5 years ago by bastiK

Replying to aseerel4c26:

JOSM version: 7777 (sorry, the full report template contains too much personal info!)

Such as ...?

comment:2 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:3 Changed 5 years ago by ToeBee

Status: newassigned

Aha. I got a blank dialog once and was going to go track it down but this explains it. When the dialog is hidden, it is not listening for new layers which means it doesn't get notified when the note layer gets created. Registering as a layer change listener during initial setup should fix this.

Changed 5 years ago by ToeBee

Attachment: empty_note_dialog.patch added

comment:4 Changed 5 years ago by ToeBee

Milestone: 14.12

comment:5 Changed 5 years ago by stoecker

Summary: notes downloaded before the notes dialog window was active do not show up in it[PATCH] notes downloaded before the notes dialog window was active do not show up in it

comment:6 Changed 5 years ago by skyper

This problem effects me even further. On the first time enabled I can not even "comment", "close" or sort notes even after redownloading.

I have to delete all notes layers in advance and then redownload to fix it.

Repository Root: http://josm.openstreetmap.de/svn
Build-Date: 2014-12-15 02:34:17
Last Changed Author: bastiK
Revision: 7804
Repository UUID: 0c6e7542-c601-0410-84e7-c038aed88b3b
Relative URL: ^/trunk
URL: http://josm.openstreetmap.de/svn/trunk
Last Changed Date: 2014-12-14 16:20:17 +0100 (Sun, 14 Dec 2014)
Last Changed Rev: 7804

Identification: JOSM/1.5 (7804 en) Linux Debian GNU/Linux 7.7 (wheezy)
Memory Usage: 362 MB / 882 MB (86 MB allocated, but free)
Java version: 1.7.0_65, Oracle Corporation, OpenJDK 64-Bit Server VM
Java package: openjdk-7-jre:amd64-7u71-2.5.3-2~deb7u1
VM arguments: [-Djosm.home=/tmp/.josm_notes2]
Program arguments: [--language=en, --set=osm.notes.enableDownload=true]
Dataset consistency test: No problems found
Last edited 5 years ago by skyper (previous) (diff)

comment:7 Changed 5 years ago by bastiK

Resolution: fixed
Status: assignedclosed

In 7809/josm:

applied #10845 - notes downloaded before the notes dialog window was active do not show up in it (patch by ToeBee)

comment:8 Changed 5 years ago by aseerel4c26

thanks. Works as expected now. Tested with Version 7819

comment:9 Changed 5 years ago by Klumbumbus

Component: CoreCore notes
Keywords: notes removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain ToeBee.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.