Modify

Opened 8 years ago

Closed 8 years ago

#10801 closed defect (fixed)

checkgroup in chunk leads to checks added multiple times

Reported by: stephankn Owned by: team
Priority: normal Milestone: 14.12
Component: Core Version: latest
Keywords: template_report preset checkgroup chunk Cc:

Description (last modified by Don-vip)

What steps will reproduce the problem?

Add attached preset. It will add the checkboxes defined in the checkgroup for each occurrence of the chunk referred.

So in case the chunk is referenced three times the checkboxes will be added three times. On each item will be nine checkboxes instead of the expected three ones.

Ungrouped check work as expected.

<presets xmlns="http://josm.openstreetmap.de/tagging-preset-1.0"
    version="201412020"
    description="checkgroup in a chunk results in multiple adds"
>
        <chunk id="mychunk">
                <checkgroup columns="1">
                        <check key="k1" text="check 1" />
                        <check key="k2" text="check 2" />
                        <check key="k3" text="check 3" />
                </checkgroup>
        </chunk>
        <item name="bug item 1">
                <reference ref="mychunk" />
        </item>
        <item name="bug item 2">
                <reference ref="mychunk" />
        </item>
        <item name="bug item 3">
                <reference ref="mychunk" />
        </item>
</presets>

What is the expected result?

three checks on each item

What happens instead?

nine checks on each item

Please provide any additional information below. Attach a screenshot if possible.

Build-Date: 2014-12-02 11:32:56
Revision: 7760
Is-Local-Build: true

Identification: JOSM/1.5 (7760 SVN en) Windows 8 64-Bit
Memory Usage: 887 MB / 5461 MB (523 MB allocated, but free)
Java version: 1.7.0_45, Oracle Corporation, Java HotSpot(TM) 64-Bit Server VM
Dataset consistency test: No problems found

Plugins:
- ImportImagePlugin (30738)
- OpeningHoursEditor (30737)
- editgpx (30737)
- geotools (30762)
- jts (30762)
- log4j (30762)
- mirrored_download (30762)
- reverter (30737)
- tagging-preset-tester (30736)

Last errors/warnings:
- W: Could not get presets icon styles/standard/misc/landuse/orchard.svg
- E: Failed to locate image 'styles/standard/misc/landuse/allotments.svg'
- W: Could not get presets icon styles/standard/misc/landuse/allotments.svg
- E: Failed to locate image 'styles/standard/misc/landuse/meadow.svg'
- W: Could not get presets icon styles/standard/misc/landuse/meadow.svg

Attachments (0)

Change History (5)

comment:1 Changed 8 years ago by Don-vip

Priority: majornormal

comment:2 Changed 8 years ago by Don-vip

Description: modified (diff)

comment:3 Changed 8 years ago by Don-vip

Keywords: preset checkgroup chunk added

comment:4 Changed 8 years ago by Don-vip

Milestone: 14.12

comment:5 Changed 8 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7889/josm:

fix #10801 - presets reading: checkgroup in chunk leads to checks added multiple times

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.