Modify

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#10691 closed enhancement (fixed)

[patch] include boundary=protected_area

Reported by: skyper Owned by: team
Priority: normal Milestone: 14.11
Component: Internal preset Version:
Keywords: boundary protected_area Cc: Klumbumbus

Description

As mentioned in #10698boundary=protected_area (wiki) is missing in defaultpresets.

Attachments (4)

josm_10691.diff (1.6 KB) - added by skyper 5 years ago.
patch
josm_10691_screenshot.png (29.1 KB) - added by skyper 5 years ago.
screenshot
josm_10691v2.diff (1.6 KB) - added by skyper 5 years ago.
patch version 2
josm_10691_wording.diff (704 bytes) - added by skyper 5 years ago.
wording patch

Download all attachments as: .zip

Change History (20)

comment:1 Changed 5 years ago by skyper

I am not sure about the place to add it within the defaultpreset as boundary is only available under relations and protected_area is valid for closed ways.

comment:2 Changed 5 years ago by Klumbumbus

Cc: Klumbumbus added

comment:3 Changed 5 years ago by Klumbumbus

boundaries are also under geography -> boundaries

Changed 5 years ago by skyper

Attachment: josm_10691.diff added

patch

Changed 5 years ago by skyper

Attachment: josm_10691_screenshot.png added

screenshot

comment:4 in reply to:  3 Changed 5 years ago by skyper

Summary: include boundary=protected_area[patch] include boundary=protected_area

Replying to Klumbumbus:

boundaries are also under geography -> boundaries

Thanks

Please find attached patch which looks like below:

screenshot

comment:5 Changed 5 years ago by Klumbumbus

There is a typo, it is protection_title not protected_title.

Of cause it is ok, to add all language specific wiki links, but it is enough if you add only the english one. The other languages will added automatically before the next stable release (a changeset like [7640]).

Changed 5 years ago by skyper

Attachment: josm_10691v2.diff added

patch version 2

comment:6 in reply to:  5 Changed 5 years ago by skyper

Replying to Klumbumbus:

There is a typo, it is protection_title not protected_title.

Thanks, please find attached a fixed version

Of cause it is ok, to add all language specific wiki links, but it is enough if you add only the english one. The other languages will added automatically before the next stable release (a changeset like [7640]).

No problem to add them once but the continually update is stupid work for computers.

comment:7 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: newclosed

In 7718/josm:

fix #10691 - add boundary=protected_area to preset (patch by skyper)

comment:8 Changed 5 years ago by Klumbumbus

Milestone: 14.11

comment:9 Changed 5 years ago by aceman

Did you really mean "destination" ? Or did you want to say "designation" ? Something like http://wiki.openstreetmap.org/wiki/Key:designation ?

comment:10 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: closedreopened

Yes, I think he meant "designation". So is "designation" the correct word used in this context? (I'm not a english native speaker.)

comment:11 in reply to:  9 ; Changed 5 years ago by skyper

Replying to aceman:

Did you really mean "destination" ? Or did you want to say "designation" ? Something like osmwiki:Key:designation ?

I did copy it from the wiki page. Please, go ahead and adjust the page if needed.

Changed 5 years ago by skyper

Attachment: josm_10691_wording.diff added

wording patch

comment:12 in reply to:  11 Changed 5 years ago by skyper

Replying to skyper:

Replying to aceman:

Did you really mean "destination" ? Or did you want to say "designation" ? Something like osmwiki:Key:designation ?

I did copy it from the wiki page. Please, go ahead and adjust the page if needed.

I did fix the wiki page and completely remove the word in presets with attached patch.

comment:13 Changed 5 years ago by Klumbumbus

Resolution: fixed
Status: reopenedclosed

In 7723/josm:

fix #10691 - fix typo (patch by skyper)

comment:14 Changed 5 years ago by Klumbumbus

In 7972/josm:

see #10691 - fix typo in key of protect_class preset

comment:15 Changed 5 years ago by Klumbumbus

In 7973/josm:

see #10691 - add validator warning for protected_class

comment:16 Changed 5 years ago by Klumbumbus

The number of protected_class raised since this bug from 31 to 81. I just fixed all 81.

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.