Modify

Opened 6 years ago

Closed 6 years ago

Last modified 5 years ago

#10666 closed enhancement (fixed)

[patch] API support for uploading note changes

Reported by: ToeBee Owned by: team
Priority: normal Milestone: 14.11
Component: Core notes Version:
Keywords: Cc: ToeBee

Description

This patch adds methods to OsmApi.java that enable JOSM to modify notes on the OSM server.

There are two utility methods at the bottom to reduce code duplication. I'm a little surprised that the functionality in the urlEncode method doesn't already exist somewhere. Or maybe I missed it. It just wraps the exception that the encode function can throw. At first I thought the fixURLQuery method in Utils could be used but it is not intended to encode user supplied strings. It intentionally leaves & and ? unencoded which is a bad thing in this case. But maybe this functionality should be put in Utils?

Attachments (1)

note_api.patch (7.1 KB) - added by ToeBee 6 years ago.

Download all attachments as: .zip

Change History (3)

Changed 6 years ago by ToeBee

Attachment: note_api.patch added

comment:1 Changed 6 years ago by Don-vip

Resolution: fixed
Status: newclosed

In 7663/josm:

fix #10666 - API support for uploading note changes (patch by ToeBee)

comment:2 Changed 5 years ago by Klumbumbus

Component: CoreCore notes
Keywords: notes removed

Modify Ticket

Change Properties
Set your email in Preferences
Action
as closed The owner will remain team.
as The resolution will be set.
The resolution will be deleted.

Add Comment


E-mail address and name can be saved in the Preferences.

 
Note: See TracTickets for help on using tickets.